Skip to content

Release-process: mention the code freeze#607

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
maelvls:code-freeze
Jun 21, 2021
Merged

Release-process: mention the code freeze#607
jetstack-bot merged 1 commit intocert-manager:masterfrom
maelvls:code-freeze

Conversation

@maelvls
Copy link
Member

@maelvls maelvls commented Jun 15, 2021 •
edited
Loading

Please review this specific paragraph:

The first beta starts a new "code freeze" period that lasts until the final release. Just before the code freeze, we fast-forward everything from master into the release branch.

During the code freeze, we continue merging PRs into master as usual.

We don't fast-forward master into the release branch for the second (and subsequent) beta, and only /cherry-pick release-1.0 the fixes that should be part of the subsequent beta.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 15, 2021
This was referenced Jun 15, 2021
Closed
Closed
SgtCoDFish
SgtCoDFish approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

this looks like a good improvement 👍

EDIT: happy to re-LGTM after the merge conflict is fixed

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@wallrj wallrj assigned maelvls and unassigned SgtCoDFish Jun 16, 2021
@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 18, 2021
@maelvls maelvls changed the base branch from code-freeze to master June 18, 2021 08:43
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 18, 2021
@cert-manager cert-manager deleted a comment from jetstack-bot Jun 18, 2021
@maelvls
release-process: mention the code freeze
3e33f1c 
Signed-off-by: Maël Valais <mael@vls.dev>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 18, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Jun 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SgtCoDFish
Copy link
Member

SgtCoDFish commented Jun 21, 2021

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2021
@jetstack-bot jetstack-bot merged commit 652b46f into cert-manager:master Jun 21, 2021
@jetstack-bot jetstack-bot mentioned this pull request Jun 25, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

@maelvls maelvls

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maelvls @jetstack-bot @SgtCoDFish