Skip to content

Roll versions forward for v1.4 release#611

Merged
jetstack-bot merged 3 commits intocert-manager:masterfrom
jakexks:1.4-release
Jun 16, 2021
Merged

Roll versions forward for v1.4 release#611
jetstack-bot merged 3 commits intocert-manager:masterfrom
jakexks:1.4-release

Conversation

@jakexks
Copy link
Member

@jakexks jakexks commented Jun 15, 2021

No description provided.

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 15, 2021
@jakexks
Copy link
Member Author

jakexks commented Jun 15, 2021

/override dco

@jetstack-bot
Copy link
Contributor

jetstack-bot commented Jun 15, 2021

@jakexks: Overrode contexts on behalf of jakexks: dco

Details

In response to this:

/override dco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 15, 2021
@jakexks
Roll versions forward for v1.4 release
0329e6e 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
@jakexks
Update installation instructions for v1.4
d6fc318 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
wallrj
wallrj approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remaining things that need updating

Here or in a followup PR and unhold

/approve
/lgtm
/hold

@jetstack-bot jetstack-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jun 15, 2021
@jakexks
Copy link
Member Author

jakexks commented Jun 15, 2021

Thanks @wallrj

Supported releases - #606

kubectl plugin I'll do in here

@jakexks
Update kubectl cert-manager installation instructions for v1.4
34c04ae 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
wallrj
wallrj approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thanks Jake.

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Jun 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maelvls maelvls mentioned this pull request Jun 16, 2021
Closed
13 tasks
@wallrj
Copy link
Member

wallrj commented Jun 16, 2021

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@jetstack-bot jetstack-bot merged commit 2bbb013 into cert-manager:master Jun 16, 2021
@jetstack-bot jetstack-bot mentioned this pull request Jun 18, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Aug 11, 2021
Merged
@wallrj wallrj mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj wallrj wallrj approved these changes

Assignees

@wallrj wallrj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakexks @jetstack-bot @wallrj