fix: [#2022] Make DetachedWindowAPI abort() test deterministic#2023
Open
TrevorBurnham wants to merge 1 commit intocapricorn86:masterfrom
Open
fix: [#2022] Make DetachedWindowAPI abort() test deterministic#2023TrevorBurnham wants to merge 1 commit intocapricorn86:masterfrom
TrevorBurnham wants to merge 1 commit intocapricorn86:masterfrom
Conversation
…stic The test 'Cancels all ongoing asynchrounous tasks' was flaky because it used setTimeout with a 10ms delay to check if waitUntilComplete() promises had resolved. This timing-based approach is unreliable in CI environments. Changed the test to: - Directly await the waitUntilComplete() promises using Promise.all() - Remove the manual Promise wrapper and setTimeout-based assertion - Keep the synchronous tasksDone check immediately after abort() This makes the test deterministic by awaiting promises directly rather than relying on arbitrary timeouts.
This was referenced Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2022
Problem
The test
DetachedWindowAPI > abort() > Cancels all ongoing asynchrounous taskswas flaky in CI, timing out with a 500ms limit. The test usedsetTimeout(..., 10)to check ifwaitUntilComplete()promises had resolved, which is unreliable in CI environments under load.Solution
Replaced the timing-based assertion with direct promise awaiting:
Changes:
waitUntilComplete()promises usingPromise.all()setTimeout-based assertiontasksDonecheck immediately afterabort()