Skip to content

fix: [#2022] Make DetachedWindowAPI abort() test deterministic #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrevorBurnham wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: [#2022] Make DetachedWindowAPI abort() test deterministic #2023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
160 changes: 76 additions & 84 deletions packages/happy-dom/test/window/DetachedWindowAPI.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,96 +183,88 @@ describe('DetachedWindowAPI', () => {

describe('abort()', () => {
it('Cancels all ongoing asynchrounous tasks.', async () => {
await new Promise((resolve) => {
const responseText = '{ "test": "test" }';
mockModule('https', {
request: () => {
return {
end: () => {},
on: (event: string, callback: (response: HTTP.IncomingMessage) => void) => {
if (event === 'response') {
async function* generate(): AsyncGenerator<string> {
yield responseText;
}

const response = <HTTP.IncomingMessage>Stream.Readable.from(generate());

response.statusCode = 200;
response.statusMessage = '';
response.headers = {
'content-length': '0'
};
response.rawHeaders = ['content-length', '0'];

setTimeout(() => callback(response));
const responseText = '{ "test": "test" }';
mockModule('https', {
request: () => {
return {
end: () => {},
on: (event: string, callback: (response: HTTP.IncomingMessage) => void) => {
if (event === 'response') {
async function* generate(): AsyncGenerator<string> {
yield responseText;
}
},
setTimeout: () => {}
};
}
});
window.location.href = 'https://localhost:8080';
let isFirstWhenAsyncCompleteCalled = false;
window.happyDOM?.waitUntilComplete().then(() => {
isFirstWhenAsyncCompleteCalled = true;
});
let tasksDone = 0;
const intervalID = window.setInterval(() => {
tasksDone++;
});
window.clearInterval(intervalID);
window.setTimeout(() => {
tasksDone++;
});
window.setTimeout(() => {
tasksDone++;
});
window.requestAnimationFrame(() => {
tasksDone++;
});
window.requestAnimationFrame(() => {
tasksDone++;
});

window
.fetch('/url/')
.then((response) =>
response
.json()
.then(() => {
tasksDone++;
})
.catch(() => {})
)
.catch(() => {});

window
.fetch('/url/')
.then((response) =>
response
.json()
.then(() => {
tasksDone++;
})
.catch(() => {})
)
.catch(() => {});

let isSecondWhenAsyncCompleteCalled = false;
window.happyDOM?.waitUntilComplete().then(() => {
isSecondWhenAsyncCompleteCalled = true;
});
const response = <HTTP.IncomingMessage>Stream.Readable.from(generate());

window.happyDOM?.abort();
response.statusCode = 200;
response.statusMessage = '';
response.headers = {
'content-length': '0'
};
response.rawHeaders = ['content-length', '0'];

expect(tasksDone).toBe(0);
setTimeout(() => callback(response));
}
},
setTimeout: () => {}
};
}
});
window.location.href = 'https://localhost:8080';

setTimeout(() => {
expect(isFirstWhenAsyncCompleteCalled).toBe(true);
expect(isSecondWhenAsyncCompleteCalled).toBe(true);
resolve(null);
}, 10);
const firstWaitPromise = window.happyDOM?.waitUntilComplete();

let tasksDone = 0;
const intervalID = window.setInterval(() => {
tasksDone++;
});
window.clearInterval(intervalID);
window.setTimeout(() => {
tasksDone++;
});
window.setTimeout(() => {
tasksDone++;
});
window.requestAnimationFrame(() => {
tasksDone++;
});
window.requestAnimationFrame(() => {
tasksDone++;
});

window
.fetch('/url/')
.then((response) =>
response
.json()
.then(() => {
tasksDone++;
})
.catch(() => {})
)
.catch(() => {});

window
.fetch('/url/')
.then((response) =>
response
.json()
.then(() => {
tasksDone++;
})
.catch(() => {})
)
.catch(() => {});

const secondWaitPromise = window.happyDOM?.waitUntilComplete();

window.happyDOM?.abort();

// Tasks should not have run yet since abort was called synchronously
expect(tasksDone).toBe(0);

// Both waitUntilComplete() promises should resolve after abort()
await Promise.all([firstWaitPromise, secondWaitPromise]);
});
});

Expand Down