fix: [#1855] Add Symbol.iterator to CSSStyleDeclaration for iteration support#2009
Open
TrevorBurnham wants to merge 1 commit intocapricorn86:masterfrom
Open
Conversation
761c6ad to
9fe2f43
Compare
capricorn86
requested changes
Feb 8, 2026
Owner
capricorn86
left a comment
There was a problem hiding this comment.
Thank you for your contribution @TrevorBurnham! ⭐
I believe that the implementation can be done in a more efficient way (see comment).
Comment on lines
+4855
to
+4858
| const length = propertyManager.size(); | ||
| for (let i = 0; i < length; i++) { | ||
| yield propertyManager.item(i); | ||
| } |
Owner
There was a problem hiding this comment.
Suggested change
| const length = propertyManager.size(); | |
| for (let i = 0; i < length; i++) { | |
| yield propertyManager.item(i); | |
| } | |
| return Object.keys(propertyManager.properties)[Symbol.iterator]](); |
I believe that this is more performant.
Contributor
Author
There was a problem hiding this comment.
Good catch! I've updated this PR to use a more performant approach for this iteration.
…r iteration support
9fe2f43 to
a6d6076
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1855
The
CSSStyleDeclarationclass was missing theSymbol.iteratorimplementation, which prevented users from iterating over style properties usingfor...ofloops, the spread operator, orArray.from().Changes
[Symbol.iterator]()generator method toCSSStyleDeclarationclassBefore
After