fix: [#1896] Call disconnectedFromNode on children in disconnectedFromNode#2021
Open
TrevorBurnham wants to merge 1 commit intocapricorn86:masterfrom
Open
fix: [#1896] Call disconnectedFromNode on children in disconnectedFromNode#2021TrevorBurnham wants to merge 1 commit intocapricorn86:masterfrom
TrevorBurnham wants to merge 1 commit intocapricorn86:masterfrom
Conversation
…onnectedFromNode Fixed a typo in Node.disconnectedFromNode() where child nodes were incorrectly calling connectedToNode() instead of disconnectedFromNode(). This bug caused nested children to not be properly disconnected when their parent was removed from the document, leaving isConnected as true for grandchildren and deeper descendants. Added test to verify nested children are properly disconnected.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1896
Problem
In
Node.disconnectedFromNode(), child nodes were incorrectly callingconnectedToNode()instead ofdisconnectedFromNode().This bug caused nested children to not be properly disconnected when their parent was removed from the document, leaving
isConnectedastruefor grandchildren and deeper descendants.Solution
Changed the call from
connectedToNode()todisconnectedFromNode():I've added test coverage to prevent future regressions.