-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration to remove region on downgrade #643
Conversation
db84b08
to
324d91e
Compare
1776af4
to
7c332c3
Compare
This push rebases on #644 which only had an updated commit message. |
324d91e
to
e641511
Compare
7c332c3
to
824d7e3
Compare
This push has no change in the implementation, it just rebases on the change from #644 that allows this migration to work even when downgrading to versions before the migrator interface change. |
e641511
to
d174748
Compare
824d7e3
to
b844548
Compare
This push just rebases on the changes from #644. |
d174748
to
d164c6d
Compare
b844548
to
6679e53
Compare
This push is just a rebase onto the changes from #637. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎
d164c6d
to
c1e9877
Compare
6679e53
to
d14f6a0
Compare
This push just rebases on a typo fix from #636. |
c1e9877
to
08136e9
Compare
d14f6a0
to
6b61f65
Compare
This push is just a rebase onto changes from #637. |
08136e9
to
6f4691b
Compare
6b61f65
to
ae03e5d
Compare
Just a rebase onto changes from #644. |
6f4691b
to
3d91ae2
Compare
ae03e5d
to
bd015f4
Compare
This push was just a rebase onto changes from #644. |
3d91ae2
to
4fed84a
Compare
Older versions don't know about this setting and would fail to deserialize the model if it's present. (We currently need to write a migration for any added/removed settings, but this will be automated away.) Region is a generated setting, so we're not throwing away anything important.
bd015f4
to
6851fa7
Compare
Rebase on develop; removed first-party exception from cargo-deny, and added migration to workspaces Cargo.toml and RELEASE.toml. (Conflict was with another migration added for 0.2.) |
Older versions don't know about this setting and would fail to deserialize the
model if it's present. (We currently need to write a migration for any
added/removed settings, but this will be automated away.)
Region is a generated setting, so we're not throwing away anything important.
Fixes #642.
Builds on #638 and #644.
Testing done:
Saved contents to make sure we write everything out:
Migrate to v0.2. We can see the migration running and saying it has nothing to do.
When v0.2 (of aws-k8s flavor) runs, it will set
settings.aws.region
:Downgrade back to v0.1. We can see the migration running and removing the region. (It removes it from
live
settings; it wasn't set inpending
, hence the second message.)Region was removed:
...and so the file list is the same as before: