Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize admin and control container URIs on region #638

Merged
merged 1 commit into from
Feb 1, 2020

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Jan 10, 2020

Builds on #636 and #637.

Fixes #231.

Testing done:

See #637. This is a separate PR to facilitate any potential discussion around actually enabling the feature, versus adding the capability, but this had to be there for testing #637.

Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌊

@tjkirch
Copy link
Contributor Author

tjkirch commented Jan 13, 2020

This push rebases onto #637 to get the typo fix caught by zmrow.

[metadata.settings.host-containers.admin.source]
setting-generator = "parameterize settings.host-containers.admin.source"
template = "328549459982.dkr.ecr.REGION.amazonaws.com/thar-admin:v0.2"
parameters = '{"REGION": "settings.aws.region"}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only nit here is the use of settings.aws.region in a global defaults.toml but we're planning to refactor that to support variants, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, every variant is aws, so this default is in the common location; we'd move it out to aws-specific variants as soon as we have something else. It might help if we have an "include" feature, or something similar, but we don't have to decide on that quite yet.

@tjkirch
Copy link
Contributor Author

tjkirch commented Jan 23, 2020

This push just rebases on the changes from #637.

@tjkirch
Copy link
Contributor Author

tjkirch commented Jan 28, 2020

This push rebases onto the new template syntax from #637. I apologize for the rebase being squashed with the changes; the only changes were in defaults.toml, where you now see just a "template" key and no longer the "parameters" key.

Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌡

@tjkirch
Copy link
Contributor Author

tjkirch commented Jan 28, 2020

This push just rebases on a typo fix from #636.

@tjkirch
Copy link
Contributor Author

tjkirch commented Jan 29, 2020

This push is just a rebase onto changes from #637.

@tjkirch tjkirch changed the base branch from parameterize to develop February 1, 2020 00:16
@tjkirch
Copy link
Contributor Author

tjkirch commented Feb 1, 2020

Just a rebase on develop because of #637, no changes.

@tjkirch tjkirch merged commit 3b669b0 into develop Feb 1, 2020
@tjkirch tjkirch deleted the parameterize-region branch February 1, 2020 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic container URI settings
4 participants