-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add platform-specific settings to API model #636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2020
zmrow
reviewed
Jan 13, 2020
zmrow
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏔
bcressey
approved these changes
Jan 22, 2020
tjkirch
force-pushed
the
platform-settings
branch
from
January 23, 2020 00:22
31024c3
to
61959c2
Compare
This push addresses Ben's concerns by:
I made a new AMI to confirm things still plumb through. |
bcressey
approved these changes
Jan 23, 2020
zmrow
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗻
webern
reviewed
Jan 28, 2020
Initially, this means setting "region" for the AWS platform. The first use case is 'region' so we can regionalize container addresses; usage will be controlled by variant-specific (and therefore platform-specific) metadata, so a platform-specific setting path doesn't hurt. In the near future, we will likely want to use region in other places, like telemetry, where we don't want applications to have to understand platform; in this case, we can abstract usage through a sundog generator that translates platform specifics to application-specific settings. Implementation is mostly in moondog. Previously, we only read user data, so it needed some restructuring to handle other data in IMDS. Now, each platform implements PlatformDataProvider. Its sole method can read user data or other metadata however it likes, and just has to return a list of Settings-like objects that it wants to be sent to the API.
tjkirch
force-pushed
the
platform-settings
branch
from
January 28, 2020 23:16
61959c2
to
846a545
Compare
This push fixes the typo caught by @webern. |
This was referenced Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, this means setting "region" for the AWS platform.
The first use case is 'region' so we can regionalize container addresses; usage
will be controlled by variant-specific (and therefore platform-specific)
metadata, so a platform-specific setting path doesn't hurt. In the near
future, we will likely want to use region in other places, like telemetry,
where we don't want applications to have to understand platform; in this case,
we can abstract usage through a sundog generator that translates platform
specifics to application-specific settings.
Implementation is mostly in moondog. Previously, we only read user data, so it
needed some restructuring to handle other data in IMDS. Now, each platform
implements PlatformDataProvider. Its sole method can read user data or other
metadata however it likes, and just has to return a list of Settings-like
objects that it wants to be sent to the API.
Testing done:
The system is healthy, pods launch OK, moondog had no errors, and the new setting shows up: