remove Tool Selection Strategy preview #6250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the experimental "Tool Selection Strategy" (router) feature, which was slow and has been superseded by newer features like Extension Manager and Code Search.
Key changes:
- Removed all router-related Rust code including selector, manager, and indexing modules
- Removed UI components and API endpoints for router configuration
- Cleaned up documentation and environment variable references
Reviewed changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ui/desktop/src/components/settings/tool_selection_strategy/ToolSelectionStrategySection.tsx | Deleted entire React component for router settings UI |
| ui/desktop/src/components/settings/chat/ChatSettingsSection.tsx | Removed router section card from chat settings |
| ui/desktop/src/api/types.gen.ts | Removed generated TypeScript types for router API |
| ui/desktop/src/api/sdk.gen.ts | Removed router API client function and imports |
| ui/desktop/openapi.json | Removed router endpoint and request schema from OpenAPI spec |
| documentation/docs/guides/managing-tools/tool-router.md | Deleted comprehensive router feature documentation |
| documentation/docs/guides/managing-tools/index.md | Removed router card from tools guide index |
| documentation/docs/guides/environment-variables.md | Removed GOOSE_ENABLE_ROUTER environment variable documentation |
| crates/goose/tests/agent.rs | Removed tool_route_manager from test context setup |
| crates/goose/src/prompts/system.md | Removed tool_selection_strategy template variable |
| crates/goose/src/prompts/router_tool_selector.md | Deleted router prompt template file |
| crates/goose/src/posthog.rs | Removed router_enabled telemetry property |
| crates/goose/src/execution/manager.rs | Removed tool_route_manager from agent context setup |
| crates/goose/src/agents/tool_router_index_manager.rs | Deleted tool indexing manager module |
| crates/goose/src/agents/tool_route_manager.rs | Deleted main router management module |
| crates/goose/src/agents/snapshots/*.snap | Updated test snapshots to remove router instructions |
| crates/goose/src/agents/router_tools.rs | Deleted router tool definitions module |
| crates/goose/src/agents/router_tool_selector.rs | Deleted LLM-based tool selector implementation |
| crates/goose/src/agents/reply_parts.rs | Simplified tool preparation by removing router logic |
| crates/goose/src/agents/prompt_manager.rs | Removed router-enabled state and prompt generation |
| crates/goose/src/agents/mod.rs | Removed router module declarations |
| crates/goose/src/agents/extension_manager_extension.rs | Simplified extension management by removing router index updates |
| crates/goose/src/agents/extension_manager.rs | Removed tool_route_manager from platform context |
| crates/goose/src/agents/extension.rs | Removed tool_route_manager from PlatformExtensionContext struct |
| crates/goose/src/agents/code_execution_extension.rs | Removed tool_route_manager from test contexts |
| crates/goose/src/agents/agent.rs | Removed router manager, tool dispatch, and all router-related methods |
| crates/goose-server/src/routes/agent.rs | Deleted update_router_tool_selector endpoint and route |
| crates/goose-server/src/openapi.rs | Removed router endpoint from API documentation |
| crates/goose-cli/src/session/builder.rs | Removed router context setup and disable_router_for_recipe call |
| crates/goose-cli/src/commands/configure.rs | Removed router configuration dialog and menu option |
Contributor
|
blackgirlbytes
approved these changes
Dec 23, 2025
angiejones
force-pushed
the
remove-llm-tool-discovery
branch
from
b051f12 to
9fc20ae
Compare
baxen
approved these changes
Dec 23, 2025
Collaborator
baxen
left a comment
baxen
left a comment
There was a problem hiding this comment.
LGTM - i tested the app and the CLI and no issues
baxen
force-pushed
the
remove-llm-tool-discovery
branch
from
028c4e4 to
9fc20ae
Compare
wpfleger96
added a commit
that referenced
this pull request
Dec 23, 2025
* main: (155 commits) remove Tool Selection Strategy preview (#6250) fix(cli): correct bash syntax in terminal integration functions (#6181) fix : opening a session to view it modifies session history order in desktop (#6156) test: fix recipe and audio tests to avoid side effects (#6231) chore: Update gemini versions in test_providers.sh (#6246) feat: option to stream json - jsonl really (#6228) feat: add mcp app renderer (#6095) docs: update skills extension to support .agents/skills directories (#6199) Add YouTube short to Chrome DevTools MCP tutorial (#6244) docs: Caveats for privacy information in logs documentation (#6218) move goose issue solver to opus (#6233) feat: improved UX for tool calls via execute_code (#6205) Blog: Code Mode Doesn't Replace MCP (#6227) fix: prevent keychain requests during cargo test (#6219) test: fix test_max_turns_limit slow execution and wrong message type (#6221) Skills vs MCP blog (#6220) Add blog post: Does Your AI Agent Need a Plan? (#6209) fix(ui): enable MCP UI to send a prompt message when an element is clicked (#6207) docs: param option for recipe deeplink/open (#6206) docs: edit in place or fork session (#6203) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed the "Tool Selection Strategy" preview feature. It was painfully slow and our newer features Extension Manager and Code Search cover this intent.
Type of Change
AI Assistance
Testing
Ran test suite locally