chore: Update gemini versions in test_providers.sh #6246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add gemini 3 flash preview to provider e2e test coverage
| "openai:gpt-4o:gpt-4o-mini:gpt-3.5-turbo:gpt-5" | ||
| "anthropic:claude-sonnet-4-5-20250929:claude-opus-4-1-20250805" | ||
| "google:gemini-2.5-pro:gemini-2.5-flash:gemini-3-pro-preview" | ||
| "google:gemini-2.5-pro:gemini-2.5-flash:gemini-3-pro-preview:gemini-3-flash-preview" |
There was a problem hiding this comment.
The model gemini-3-flash-preview is being added to the test script but is missing from the GOOGLE_KNOWN_MODELS constant in crates/goose/src/providers/google.rs. The known models list should include this model for consistency with the test coverage.
Suggested change
| "google:gemini-2.5-pro:gemini-2.5-flash:gemini-3-pro-preview:gemini-3-flash-preview" | |
| "google:gemini-2.5-pro:gemini-2.5-flash:gemini-3-pro-preview" |
codefromthecrypt
approved these changes
Dec 23, 2025
Collaborator
codefromthecrypt
left a comment
codefromthecrypt
left a comment
There was a problem hiding this comment.
assuming we can ignore the copilot thing
Collaborator
Author
|
yeah - eventually we drop the -preview. |
wpfleger96
added a commit
that referenced
this pull request
Dec 23, 2025
* main: (155 commits) remove Tool Selection Strategy preview (#6250) fix(cli): correct bash syntax in terminal integration functions (#6181) fix : opening a session to view it modifies session history order in desktop (#6156) test: fix recipe and audio tests to avoid side effects (#6231) chore: Update gemini versions in test_providers.sh (#6246) feat: option to stream json - jsonl really (#6228) feat: add mcp app renderer (#6095) docs: update skills extension to support .agents/skills directories (#6199) Add YouTube short to Chrome DevTools MCP tutorial (#6244) docs: Caveats for privacy information in logs documentation (#6218) move goose issue solver to opus (#6233) feat: improved UX for tool calls via execute_code (#6205) Blog: Code Mode Doesn't Replace MCP (#6227) fix: prevent keychain requests during cargo test (#6219) test: fix test_max_turns_limit slow execution and wrong message type (#6221) Skills vs MCP blog (#6220) Add blog post: Does Your AI Agent Need a Plan? (#6209) fix(ui): enable MCP UI to send a prompt message when an element is clicked (#6207) docs: param option for recipe deeplink/open (#6206) docs: edit in place or fork session (#6203) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cover gemini 3 flash (preview)