test: fix test_max_turns_limit slow execution and wrong message type #6221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. max_turns: None defaults to 1000 turns - restore Some(1) 2. Checked for ToolConfirmationRequest but agent sends ActionRequired Signed-off-by: Adrian Cole <adrian@tetrate.io>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes slow test execution in test_max_turns_limit by correcting two issues: restoring the max_turns limit from None (which defaults to 1000 iterations) to Some(1), and updating the message type pattern matching to use ActionRequired with ToolConfirmation data instead of the deprecated ToolConfirmationRequest type.
- Restored
max_turns: Some(1)to prevent 1000-iteration default - Updated message pattern matching to use current
ActionRequiredAPI
michaelneale
approved these changes
Dec 21, 2025
cronus42
pushed a commit
to cronus42/goose
that referenced
this pull request
Dec 22, 2025
…lock#6221) Signed-off-by: Adrian Cole <adrian@tetrate.io>
wpfleger96
added a commit
that referenced
this pull request
Dec 23, 2025
* main: (155 commits) remove Tool Selection Strategy preview (#6250) fix(cli): correct bash syntax in terminal integration functions (#6181) fix : opening a session to view it modifies session history order in desktop (#6156) test: fix recipe and audio tests to avoid side effects (#6231) chore: Update gemini versions in test_providers.sh (#6246) feat: option to stream json - jsonl really (#6228) feat: add mcp app renderer (#6095) docs: update skills extension to support .agents/skills directories (#6199) Add YouTube short to Chrome DevTools MCP tutorial (#6244) docs: Caveats for privacy information in logs documentation (#6218) move goose issue solver to opus (#6233) feat: improved UX for tool calls via execute_code (#6205) Blog: Code Mode Doesn't Replace MCP (#6227) fix: prevent keychain requests during cargo test (#6219) test: fix test_max_turns_limit slow execution and wrong message type (#6221) Skills vs MCP blog (#6220) Add blog post: Does Your AI Agent Need a Plan? (#6209) fix(ui): enable MCP UI to send a prompt message when an element is clicked (#6207) docs: param option for recipe deeplink/open (#6206) docs: edit in place or fork session (#6203) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed two issues with
test_max_turns_limitthat caused it to run extremely slowly:max_turns: Nonedefaults to 1000 turns - restored toSome(1)ToolConfirmationRequestbut agent sendsActionRequiredwithToolConfirmationdataType of Change
AI Assistance
Testing
Test now completes in ~0.5s instead of running 1000 turns.
Related Issues
Relates to #5548