fix(ui): enable MCP UI to send a prompt message when an element is clicked #6207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug where MCP UI prompts were not being submitted to the chat. The append prop was missing from the ProgressiveMessageList component in BaseChat, causing interactive buttons in MCP UI resources to call an empty default function instead of actually submitting prompts. Additionally, the MCP Elicitation documentation page is being made publicly visible.
- Wires up the
appendprop to enable MCP UI prompt submission - Removes
unlisted: truefrom MCP Elicitation documentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/desktop/src/components/BaseChat.tsx | Adds missing append prop to ProgressiveMessageList component, linking it to handleSubmit |
| documentation/docs/guides/mcp-elicitation.md | Removes unlisted: true to make the MCP Elicitation guide publicly visible |
Contributor
|
blackgirlbytes
changed the title
…mpts The append prop was not being passed from BaseChat to ProgressiveMessageList, which meant MCP UI buttons that send 'prompt' type postMessages were calling an empty default function instead of actually submitting to the chat. This fix enables MCP UI interactive buttons to work properly by connecting the prompt action handler to handleSubmit.
blackgirlbytes
force-pushed
the
fix/mcp-ui-append-prop
branch
from
6673186 to
98217c3
Compare
wpfleger96
added a commit
that referenced
this pull request
Dec 23, 2025
* main: (155 commits) remove Tool Selection Strategy preview (#6250) fix(cli): correct bash syntax in terminal integration functions (#6181) fix : opening a session to view it modifies session history order in desktop (#6156) test: fix recipe and audio tests to avoid side effects (#6231) chore: Update gemini versions in test_providers.sh (#6246) feat: option to stream json - jsonl really (#6228) feat: add mcp app renderer (#6095) docs: update skills extension to support .agents/skills directories (#6199) Add YouTube short to Chrome DevTools MCP tutorial (#6244) docs: Caveats for privacy information in logs documentation (#6218) move goose issue solver to opus (#6233) feat: improved UX for tool calls via execute_code (#6205) Blog: Code Mode Doesn't Replace MCP (#6227) fix: prevent keychain requests during cargo test (#6219) test: fix test_max_turns_limit slow execution and wrong message type (#6221) Skills vs MCP blog (#6220) Add blog post: Does Your AI Agent Need a Plan? (#6209) fix(ui): enable MCP UI to send a prompt message when an element is clicked (#6207) docs: param option for recipe deeplink/open (#6206) docs: edit in place or fork session (#6203) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
appendprop was not being passed fromBaseChattoProgressiveMessageList, which meant MCP UI buttons that sendprompttype postMessages were calling an empty default function() => {}instead of actually submitting to the chat.Problem
When an MCP UI (rendered via
MCPUIResourceRenderer) sends a prompt message like:The message was received by
@mcp-ui/client, which calledappendPromptToChat(prompt)inMCPUIResourceRenderer. However, sinceappendwas not passed down through the component chain, it defaulted to an empty function and nothing happened.Fix
Added the missing
appendprop toProgressiveMessageListinBaseChat.tsx:Testing
Related
This fix is also required for the MCP Apps feature branch (
feat/add-mcp-app-renderer) to work properly, as it also relies on theappendprop flowing down fromBaseChat.Broken version
Screen.Recording.2025-12-19.at.5.37.47.PM.mov
Fixed version
Screen.Recording.2025-12-19.at.5.35.57.PM.mov
watch on 2x speed