Fix Claude Code provider to default to Auto mode (#5638) #5642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make Claude Code provider consistent with rest of codebase by using .unwrap_or(GooseMode::Auto) when GOOSE_MODE is not set. Previously, when GOOSE_MODE was not configured, Claude CLI was invoked without permission flags, causing it to ask for permission on every file edit.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies error handling in the apply_permission_flags method of the Claude Code provider by using unwrap_or to provide a default value instead of explicit error matching.
- Extracted
get_goose_mode()call with default value handling into a separate variable - Simplified the match expression by removing
Ok()wrappers and the explicit error handling branch - Maintains the same behavior with cleaner, more idiomatic Rust code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DOsinga
approved these changes
Nov 8, 2025
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
Wow, nice catch. Smells like LLM written code before. I didn't know we had this
Collaborator
|
oh good catch - I didn't know it couldn't be set (mine always has been, always showed up in config as |
michaelneale
added a commit
that referenced
this pull request
Nov 10, 2025
* main: (33 commits) Fix Claude Code provider to default to Auto mode (#5638) (#5642) Scheduler cleanup (#5571) Better search paths and handling of CLI providers (#5554) docs: description required for "Add Extension" in cli - phase 2 (#5635) Remove some logging (#5631) Use session IDs as task IDs for subagents instead of UUIDs (#5398) Fix the naming (#5628) fix: default tetrate model is broken, replace with haiku-4.5 (#5535) (#5587) Fetch less and use the right SHA (#5621) feat(ui): add custom macOS dock menu with New Window option (#5099) feat: remove hints from recipe prompts (#5622) docs: October 2025 Community All-Stars spotlight, Hacktoberfest edition (#5625) differentiate debug/release in cache key (#5613) Unify subrecipe and subagent execution through shared recipe pipeline (#5082) Standardize CLI argument flags and update documentation (#5516) Release 1.13.0 fix: move goosehints/AGENTS.md handling to goose, and out of developer extension (#5575) fix: add standard context menu items to prevent empty right-click menu (#5616) Bump openapi in prepare-release (#5611) docs: add access control section to Developer tutorial (#5615) ...
tiensi
added a commit
to tiensi/goose
that referenced
this pull request
Nov 11, 2025
* main: (83 commits) silence copilot on minor text issues (block#5665) fix: disallow runaway subagent chains (block#5659) chore: remove usage of non-existent env var for log dir (block#5658) clarify agent instructions (block#5655) feat: add check-everything for unified style checks (block#5650) Show errors on failure (block#5643) custom instructions for copilot reviews (block#5646) fix: prevent repeated 404 errors when accessing deleted sessions (block#5644) Flake.nix corrected main (block#5600) fix: goose recipe list can return duplicated entries (block#5645) fix: bedrock creds refresh (block#5599) Fix Claude Code provider to default to Auto mode (block#5638) (block#5642) Scheduler cleanup (block#5571) Better search paths and handling of CLI providers (block#5554) docs: description required for "Add Extension" in cli - phase 2 (block#5635) Remove some logging (block#5631) Use session IDs as task IDs for subagents instead of UUIDs (block#5398) Fix the naming (block#5628) fix: default tetrate model is broken, replace with haiku-4.5 (block#5535) (block#5587) Fetch less and use the right SHA (block#5621) ...
Surendhar-N-D
pushed a commit
to Surendhar-N-D/goose
that referenced
this pull request
Nov 17, 2025
arul-cc
pushed a commit
to arul-cc/goose
that referenced
this pull request
Nov 17, 2025
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
…5642) Signed-off-by: Blair Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make Claude Code provider consistent with rest of codebase by using .unwrap_or(GooseMode::Auto) when GOOSE_MODE is not set. Previously, when GOOSE_MODE was not configured, Claude CLI was invoked without permission flags, causing it to ask for permission on every file edit.
Type of Change
AI Assistance
(used goose)
Testing
Manual testing
Related Issues
Relates to #5638
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
After:
