-
Notifications
You must be signed in to change notification settings - Fork 2.4k
docs: description required for "Add Extension" in cli #5573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR standardizes product naming from "Goose" to lowercase "goose" across documentation and updates extension installation instructions to require a description field instead of making it optional.
- Changed product name from "Goose" to "goose" throughout documentation
- Made the description field required for CLI extension configuration
- Updated installation confirmation dialog from "OK" to "Yes"
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
CLIExtensionInstructions.tsx |
Added required description prop and updated CLI prompts to require extension descriptions instead of making them optional |
GooseDesktopInstaller.tsx |
Updated installation confirmation button text from "OK" to "Yes" |
Multiple .md files in docs/mcp/ |
Standardized product name from "Goose" to "goose" in descriptions, headings, and content |
_template_.mdx |
Updated template structure to include required description field and modernized component examples |
mcp-ui.md |
Changed "Goose" to "goose" in description and content |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| interface CLIExtensionInstructionsProps { | ||
| name: string; | ||
| description: string; |
Copilot
AI
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description field is now required in the interface but there's no validation or fallback. Since this is a breaking change to the component API, consider adding a runtime check or default value to prevent runtime errors if existing consumers haven't updated their code yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is n/a because it's consistent with the other required fields (no fallback) and this PR updates all existing consumers of this component.
| ? <>Add {envVars.length > 1 ? 'custom headers' : 'a custom header'} for this extension.</> | ||
| : <>Add {envVars.length > 1 ? 'environment variables' : 'an environment variable'} for this extension.</> |
Copilot
AI
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The refactored text uses 'this extension' instead of the extension name. While this is more generic, it may be less clear to users. The previous version for ${name} provided specific context about which extension was being configured.
| ? <>Add {envVars.length > 1 ? 'custom headers' : 'a custom header'} for this extension.</> | |
| : <>Add {envVars.length > 1 ? 'environment variables' : 'an environment variable'} for this extension.</> | |
| ? <>Add {envVars.length > 1 ? 'custom headers' : 'a custom header'} for <strong>{name}</strong>.</> | |
| : <>Add {envVars.length > 1 ? 'environment variables' : 'an environment variable'} for <strong>{name}</strong>.</> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"this extension" is consistent with other steps and doesn't need specific context. It's also better grammatically.
|
…est-and-fix * 'main' of github.com:block/goose: Document missing recipe param types (#5584) docs: description required for "Add Extension" in cli (#5573) fix: Add schema-aware numeric coercion for MCP tool arguments (#5478) Add uv for uvx in Justfile (#5581) Keep llm logs in place (#5577) bump to 1.12.0 (#5580) automate more of the release process (#5409) add clippy warning for string_slice (#5422)
* main: (41 commits) Add pending extension indicator to extension panel (#5493) Add environment subsition for auth blocks (#5439) acp: ToolCallLocations and working cancellation (#5588) feat(providers): add Mistral AI provider (#5009) Listen for ctrl-c during provider request (#5585) Also accept null as description, not just missing (#5589) Document missing recipe param types (#5584) docs: description required for "Add Extension" in cli (#5573) fix: Add schema-aware numeric coercion for MCP tool arguments (#5478) Add uv for uvx in Justfile (#5581) Keep llm logs in place (#5577) bump to 1.12.0 (#5580) automate more of the release process (#5409) add clippy warning for string_slice (#5422) improve linux tray icon support (#5425) feat: log rotation (#5561) use app.isPackaged instead of checking for node env development (#5465) disable RPM build-ID generation to prevent package conflicts (#5563) Add Diagnostics Info to Q&A and Bug Report Templates (#5565) fix: improve server error messages to include HTTP status code (#5532) ...
* main: (53 commits) acp: ToolCallLocations and working cancellation (#5588) feat(providers): add Mistral AI provider (#5009) Listen for ctrl-c during provider request (#5585) Also accept null as description, not just missing (#5589) Document missing recipe param types (#5584) docs: description required for "Add Extension" in cli (#5573) fix: Add schema-aware numeric coercion for MCP tool arguments (#5478) Add uv for uvx in Justfile (#5581) Keep llm logs in place (#5577) bump to 1.12.0 (#5580) automate more of the release process (#5409) add clippy warning for string_slice (#5422) improve linux tray icon support (#5425) feat: log rotation (#5561) use app.isPackaged instead of checking for node env development (#5465) disable RPM build-ID generation to prevent package conflicts (#5563) Add Diagnostics Info to Q&A and Bug Report Templates (#5565) fix: improve server error messages to include HTTP status code (#5532) improvement: add useful error message when attempting to use unauthenticated cursor-agent (#5300) fix: unblock acp via databricks (#5562) ...
* main: fix: customised recipe to yaml string to avoid minininjia parsing error (#5494) Add pending extension indicator to extension panel (#5493) Add environment subsition for auth blocks (#5439) acp: ToolCallLocations and working cancellation (#5588) feat(providers): add Mistral AI provider (#5009) Listen for ctrl-c during provider request (#5585) Also accept null as description, not just missing (#5589) Document missing recipe param types (#5584) docs: description required for "Add Extension" in cli (#5573) fix: Add schema-aware numeric coercion for MCP tool arguments (#5478) Add uv for uvx in Justfile (#5581) Keep llm logs in place (#5577) bump to 1.12.0 (#5580) automate more of the release process (#5409)
* origin/main: (75 commits) fix: customised recipe to yaml string to avoid minininjia parsing error (#5494) Add pending extension indicator to extension panel (#5493) Add environment subsition for auth blocks (#5439) acp: ToolCallLocations and working cancellation (#5588) feat(providers): add Mistral AI provider (#5009) Listen for ctrl-c during provider request (#5585) Also accept null as description, not just missing (#5589) Document missing recipe param types (#5584) docs: description required for "Add Extension" in cli (#5573) fix: Add schema-aware numeric coercion for MCP tool arguments (#5478) Add uv for uvx in Justfile (#5581) Keep llm logs in place (#5577) bump to 1.12.0 (#5580) automate more of the release process (#5409) add clippy warning for string_slice (#5422) improve linux tray icon support (#5425) feat: log rotation (#5561) use app.isPackaged instead of checking for node env development (#5465) disable RPM build-ID generation to prevent package conflicts (#5563) Add Diagnostics Info to Q&A and Bug Report Templates (#5565) ...
Signed-off-by: fbalicchia <[email protected]>
Signed-off-by: Blair Allan <[email protected]>
Summary
This PR updates tutorials to sync with the change to the
goose configureflow that requires a description when adding an extension. It also updates the Apify and GitHub tutorials to use install links and changes to lowercase "goose" in touched files.This is PHASE 1 of the updates for the
descriptionrequirement and only includes tutorials that use theCLIExtensionInstructionscomponent.Documentation updates:
Update components:
documentation/src/components/CLIExtensionInstructions.tsx:descriptionfieldsrc/components/GooseDesktopInstaller.tsx:Add
descriptionfield to CLI config:documentation/docs/mcp/_template_.mdx:documentation/docs/guides/interactive-chat/mcp-ui.mddocumentation/docs/mcp/apify-mcp.md:documentation/docs/mcp/container-use-mcp.mddocumentation/docs/mcp/dev.to-mcp.mddocumentation/docs/mcp/figma-mcp.mddocumentation/docs/mcp/firecrawl-mcp.mddocumentation/docs/mcp/github-mcp.md:documentation/docs/mcp/gitmcp-mcp.mddocumentation/docs/mcp/goose-docs-mcp.mddocumentation/docs/mcp/gotohuman-mcp.mddocumentation/docs/mcp/jetbrains-mcp.mddocumentation/docs/mcp/neon-mcp.mddocumentation/docs/mcp/reddit-mcp.mddocumentation/docs/mcp/rube-mcp.mddocumentation/docs/mcp/vercel-mcp.mdType of Change
Testing
Manual testing of doc rendering plus a couple misc install flows