Skip to content

feat(shell): throw errors on interactive commands #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelneale merged 2 commits into from
Sep 24, 2025
Merged

feat(shell): throw errors on interactive commands #4788

michaelneale merged 2 commits into from
Sep 24, 2025

Conversation

@exitcode0
Copy link
Contributor

@exitcode0 exitcode0 commented Sep 24, 2025 •
edited
Loading

Description

Configures the developer / shells to throw errors when using unsupported interactive commands

Commands like git commit (without -m) & git rebase -i would previously timeout or need canceling manually

This is change is a bit of a hack and we should revisit this in the future
🤞 we can figure out how to set EDITOR up to call the file-edit tool

@exitcode0
feat: block interactive commands in shell
303c00c 
configure env vars to throw errors when using interactive commands in
the shell/developer tool
@DOsinga
Copy link
Collaborator

DOsinga commented Sep 24, 2025

This is change is a bit of a hack and we should revisit this in the future

what do you mean by that? how would we revisit this?

DOsinga
DOsinga approved these changes Sep 24, 2025
View reviewed changes
Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement. but please delete the tests

@exitcode0
Copy link
Contributor Author

exitcode0 commented Sep 24, 2025

This is change is a bit of a hack and we should revisit this in the future

what do you mean by that? how would we revisit this?

My thinking is that it might be possible to set EDITOR up in such a way that we hand off to the current file editor tool or something similar
because git is only checking the exit code of the processed called from EDITOR, we could hand off to a file editor tool, we could then use that to complete whatever edits are required, then we exit and git / the shell MCP takes back over
That's still entirely theoretical though, I haven't looked at any of that code, i'm also not sure if MCP supports something like that

@michaelneale
Copy link
Collaborator

michaelneale commented Sep 24, 2025

oh @exitcode0 that is fantastic, yeah that should help a lot of frustrating hanging.

@michaelneale michaelneale merged commit bde47eb into block:main Sep 24, 2025
10 checks passed
zanesq added a commit that referenced this pull request Sep 24, 2025
@zanesq
Merge branch 'main' of github.com:block/goose into zane/create-recipe…
c66d934 
…-unification

* 'main' of github.com:block/goose:
  Add elapsed time to the CLI output. (#4609)
  fix: Fix cell coordinate ordering in XlsxTool and add unit tests (#4551)
  Use gemini flash for summarization on open router (#4290)
  chore(deps): bump xcb from 1.5.0 to 1.6.0 (#4289)
  feat(shell): throw errors on interactive commands (#4788)
  feat: AgentManager - foundation for unified execution (#4389) (#4684)
  shave and code split (#4630)
  docs: acp support (#4793)
  Add Take Action for Hacktoberfest (#4791)
  Remove now unused mcp-server crate (#4773)
  Release/1.9.0 (#4703)
  chore(mcp): convert computercontroller server to use the rust sdk (#4772)
  Docs: Delete sessions from UI and edit has changed (#4785)
  Don't load user's shell env on app startup (#4681)
  Docs: Chrome Dev Tools Extension Tutorial (#4783)
  Add Hacktoberfest 2025 Leaderboard Workflow (#4776)

# Conflicts:
#	crates/goose-server/src/routes/recipe.rs
#	ui/desktop/openapi.json
#	ui/desktop/src/api/types.gen.ts
#	ui/desktop/src/hooks/useRecipeManager.ts
#	ui/desktop/src/recipe/index.ts
zanesq added a commit that referenced this pull request Sep 24, 2025
@zanesq
Merge branch 'zane/create-recipe-unification' of github.com:block/goo…
b484995 
…se into zane/recipe-param-values-resume

* 'zane/create-recipe-unification' of github.com:block/goose:
  fix recipe issues from upstream changes and regenerate types
  Add elapsed time to the CLI output. (#4609)
  fix: Fix cell coordinate ordering in XlsxTool and add unit tests (#4551)
  Use gemini flash for summarization on open router (#4290)
  chore(deps): bump xcb from 1.5.0 to 1.6.0 (#4289)
  feat(shell): throw errors on interactive commands (#4788)
  feat: AgentManager - foundation for unified execution (#4389) (#4684)
  shave and code split (#4630)
  docs: acp support (#4793)
  Add Take Action for Hacktoberfest (#4791)
  fix recipe instructions from session metadata not being injected
  Remove now unused mcp-server crate (#4773)
  Release/1.9.0 (#4703)
  chore(mcp): convert computercontroller server to use the rust sdk (#4772)
  Docs: Delete sessions from UI and edit has changed (#4785)
  Don't load user's shell env on app startup (#4681)
  Docs: Chrome Dev Tools Extension Tutorial (#4783)
  Add Hacktoberfest 2025 Leaderboard Workflow (#4776)

# Conflicts:
#	ui/desktop/src/hooks/useAgent.ts
#	ui/desktop/src/utils/providerUtils.ts
zanesq added a commit that referenced this pull request Sep 24, 2025
@zanesq
Merge branch 'zane/recipe-param-values-resume' of github.com:block/go…
1401115 
…ose into zane/create-edit-recipe-tests

* 'zane/recipe-param-values-resume' of github.com:block/goose:
  fix recipe issues from upstream changes and regenerate types
  Add elapsed time to the CLI output. (#4609)
  fix: Fix cell coordinate ordering in XlsxTool and add unit tests (#4551)
  Use gemini flash for summarization on open router (#4290)
  chore(deps): bump xcb from 1.5.0 to 1.6.0 (#4289)
  feat(shell): throw errors on interactive commands (#4788)
  feat: AgentManager - foundation for unified execution (#4389) (#4684)
  shave and code split (#4630)
  docs: acp support (#4793)
  Add Take Action for Hacktoberfest (#4791)
  fix recipe instructions from session metadata not being injected
  Remove now unused mcp-server crate (#4773)
  Release/1.9.0 (#4703)
  chore(mcp): convert computercontroller server to use the rust sdk (#4772)
  Docs: Delete sessions from UI and edit has changed (#4785)
  Don't load user's shell env on app startup (#4681)
  Docs: Chrome Dev Tools Extension Tutorial (#4783)
  Add Hacktoberfest 2025 Leaderboard Workflow (#4776)
tlongwell-block pushed a commit that referenced this pull request Sep 25, 2025
@exitcode0 @tlongwell-block
feat(shell): throw errors on interactive commands (#4788)
3da80fa
@DOsinga
Copy link
Collaborator

DOsinga commented Sep 25, 2025

My thinking is that it might be possible to set EDITOR up in such a way that we hand off to the current file editor tool or something similar because git is only checking the exit code of the processed called from EDITOR, we could hand off to a file editor tool, we could then use that to complete whatever edits are required, then we exit and git / the shell MCP takes back over That's still entirely theoretical though, I haven't looked at any of that code, i'm also not sure if MCP supports something like that

those are good musings, but probably drop the comment

katzdave added a commit that referenced this pull request Sep 25, 2025
@katzdave
Merge branch 'main' of github.com:block/goose into dkatz/desktop-impr…
21e9e8f 
…ovements

* 'main' of github.com:block/goose: (23 commits)
  blog post on subagents vs subrecipes (#4829)
  fix chat button alignment and spacing for attachments (#4794)
  fix: remove nested double quotes in windows automation_script tool description (#4824)
  fix: a few things with the mcp snapshot test (#4818)
  Revert "fix(compaction): try to catch more context limit exceeded erors and compact" (#4820)
  test: add test coverage for Tools Inspector (#4700)
  feat: Parse and use retryDelay from Google API RateLimitExceeded errors (#4124)
  cleanup: remove unused link preview and goose response form components (#4795)
  fix build: latest bedrock version (#4812)
  prefer users SHELL (#4702)
  feat: update aws-sdk-bedrockruntime to enable AWS_BEARER_TOKEN_BEDROCK auth (#4327)
  correct the tests from an odd merge (#4804)
  docs: import yaml recipe (#4799)
  docs: Add openmetadata extension to goose mcp docs (#4547)
  Add elapsed time to the CLI output. (#4609)
  fix: Fix cell coordinate ordering in XlsxTool and add unit tests (#4551)
  Use gemini flash for summarization on open router (#4290)
  chore(deps): bump xcb from 1.5.0 to 1.6.0 (#4289)
  feat(shell): throw errors on interactive commands (#4788)
  feat: AgentManager - foundation for unified execution (#4389) (#4684)
  ...
HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025
@exitcode0 @HikaruEgashira
feat(shell): throw errors on interactive commands (block#4788)
ef439e9 
Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>
This was referenced Oct 8, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelneale michaelneale michaelneale approved these changes

@DOsinga DOsinga DOsinga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@exitcode0 @DOsinga @michaelneale