fix: Fix cell coordinate ordering in XlsxTool and add unit tests #4551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct swapped row/col indices in get_cell, get_cell_mut, and related methods. Added tests for B1 and A2 cells to verify proper coordinate handling. see: https://docs.rs/umya-spreadsheet/2.3.2/src/umya_spreadsheet/structs/worksheet.rs.html#240 Signed-off-by: kita-sato <[email protected]>
DOsinga
approved these changes
Sep 19, 2025
| assert!(b1_cell.formula.is_none()); | ||
|
|
||
| // Test A2 cell (known value from FinancialSample.xlsx) | ||
| let a2_cell = xlsx.get_cell_value(worksheet, 2, 1)?; |
Collaborator
There was a problem hiding this comment.
remove the comments about known value. if you want to say something about this, change get_cell_value to take a string and do the row col parsing there, which would make the test easier to read
katzdave
approved these changes
Sep 24, 2025
zanesq
added a commit
that referenced
this pull request
Sep 24, 2025
…-unification * 'main' of github.com:block/goose: Add elapsed time to the CLI output. (#4609) fix: Fix cell coordinate ordering in XlsxTool and add unit tests (#4551) Use gemini flash for summarization on open router (#4290) chore(deps): bump xcb from 1.5.0 to 1.6.0 (#4289) feat(shell): throw errors on interactive commands (#4788) feat: AgentManager - foundation for unified execution (#4389) (#4684) shave and code split (#4630) docs: acp support (#4793) Add Take Action for Hacktoberfest (#4791) Remove now unused mcp-server crate (#4773) Release/1.9.0 (#4703) chore(mcp): convert computercontroller server to use the rust sdk (#4772) Docs: Delete sessions from UI and edit has changed (#4785) Don't load user's shell env on app startup (#4681) Docs: Chrome Dev Tools Extension Tutorial (#4783) Add Hacktoberfest 2025 Leaderboard Workflow (#4776) # Conflicts: # crates/goose-server/src/routes/recipe.rs # ui/desktop/openapi.json # ui/desktop/src/api/types.gen.ts # ui/desktop/src/hooks/useRecipeManager.ts # ui/desktop/src/recipe/index.ts
zanesq
added a commit
that referenced
this pull request
Sep 24, 2025
…se into zane/recipe-param-values-resume * 'zane/create-recipe-unification' of github.com:block/goose: fix recipe issues from upstream changes and regenerate types Add elapsed time to the CLI output. (#4609) fix: Fix cell coordinate ordering in XlsxTool and add unit tests (#4551) Use gemini flash for summarization on open router (#4290) chore(deps): bump xcb from 1.5.0 to 1.6.0 (#4289) feat(shell): throw errors on interactive commands (#4788) feat: AgentManager - foundation for unified execution (#4389) (#4684) shave and code split (#4630) docs: acp support (#4793) Add Take Action for Hacktoberfest (#4791) fix recipe instructions from session metadata not being injected Remove now unused mcp-server crate (#4773) Release/1.9.0 (#4703) chore(mcp): convert computercontroller server to use the rust sdk (#4772) Docs: Delete sessions from UI and edit has changed (#4785) Don't load user's shell env on app startup (#4681) Docs: Chrome Dev Tools Extension Tutorial (#4783) Add Hacktoberfest 2025 Leaderboard Workflow (#4776) # Conflicts: # ui/desktop/src/hooks/useAgent.ts # ui/desktop/src/utils/providerUtils.ts
zanesq
added a commit
that referenced
this pull request
Sep 24, 2025
…ose into zane/create-edit-recipe-tests * 'zane/recipe-param-values-resume' of github.com:block/goose: fix recipe issues from upstream changes and regenerate types Add elapsed time to the CLI output. (#4609) fix: Fix cell coordinate ordering in XlsxTool and add unit tests (#4551) Use gemini flash for summarization on open router (#4290) chore(deps): bump xcb from 1.5.0 to 1.6.0 (#4289) feat(shell): throw errors on interactive commands (#4788) feat: AgentManager - foundation for unified execution (#4389) (#4684) shave and code split (#4630) docs: acp support (#4793) Add Take Action for Hacktoberfest (#4791) fix recipe instructions from session metadata not being injected Remove now unused mcp-server crate (#4773) Release/1.9.0 (#4703) chore(mcp): convert computercontroller server to use the rust sdk (#4772) Docs: Delete sessions from UI and edit has changed (#4785) Don't load user's shell env on app startup (#4681) Docs: Chrome Dev Tools Extension Tutorial (#4783) Add Hacktoberfest 2025 Leaderboard Workflow (#4776)
tlongwell-block
pushed a commit
that referenced
this pull request
Sep 25, 2025
Signed-off-by: kita-sato <[email protected]>
katzdave
added a commit
that referenced
this pull request
Sep 25, 2025
…ovements * 'main' of github.com:block/goose: (23 commits) blog post on subagents vs subrecipes (#4829) fix chat button alignment and spacing for attachments (#4794) fix: remove nested double quotes in windows automation_script tool description (#4824) fix: a few things with the mcp snapshot test (#4818) Revert "fix(compaction): try to catch more context limit exceeded erors and compact" (#4820) test: add test coverage for Tools Inspector (#4700) feat: Parse and use retryDelay from Google API RateLimitExceeded errors (#4124) cleanup: remove unused link preview and goose response form components (#4795) fix build: latest bedrock version (#4812) prefer users SHELL (#4702) feat: update aws-sdk-bedrockruntime to enable AWS_BEARER_TOKEN_BEDROCK auth (#4327) correct the tests from an odd merge (#4804) docs: import yaml recipe (#4799) docs: Add openmetadata extension to goose mcp docs (#4547) Add elapsed time to the CLI output. (#4609) fix: Fix cell coordinate ordering in XlsxTool and add unit tests (#4551) Use gemini flash for summarization on open router (#4290) chore(deps): bump xcb from 1.5.0 to 1.6.0 (#4289) feat(shell): throw errors on interactive commands (#4788) feat: AgentManager - foundation for unified execution (#4389) (#4684) ...
HikaruEgashira
pushed a commit
to HikaruEgashira/goose
that referenced
this pull request
Oct 3, 2025
…ck#4551) Signed-off-by: kita-sato <[email protected]> Signed-off-by: HikaruEgashira <[email protected]>
This was referenced Oct 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #4550
Correct swapped row/col indices in get_cell, get_cell_mut, and related methods. Added tests for B1 and A2 cells to verify proper coordinate handling.
see: https://docs.rs/umya-spreadsheet/2.3.2/src/umya_spreadsheet/structs/worksheet.rs.html#240