fix: ollama streaming patch #4364
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'main' of github.com:GACWR/goose: stream for ollama
DOsinga
approved these changes
Aug 27, 2025
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
Looks good, but let's dedupe the code
| } | ||
| })) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
this is identical to the streaming implementation of OpenAI. we should reuse that code
Collaborator
Author
|
closing as folded in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
building off #4303 - correctly sets the strreaming flag and actually does stream, improves performance of ollama a bit at least subjectively
thanks @Jovonni