Fix working directory when session has no messages

[s-soroosh]

• Fixes Goose CLI: Working dir not properly set for new sessions #2790

Previously, when a session had no messages or an invalid working directory, it would default to the home directory. This changes the behavior to use the current working directory instead, which I think is more intuitive and matches user expectations.

Questions

• Is there any drawback to use cwd as the default working directory instead of home directory?

Step to reproduce the problem:

• Go to any folder
• call goose to create a new session
• Quit goose
• Resume the session
• Observe the warning WARNING: The original working directory of this session was set to "your home directory"

With this Fix
Next time you resume the session created "after applying this fix" will be associated with the correct working directory even if session is empty.

[s-soroosh]

@michaelneale In the description I outlined how the issue can be reproduced.

[taniandjerry]

Thank you for outlining the issue and how to reproduce it! For reference, this is happening for users on Mac and Linux #2790

[DOsinga]

excellent. I wonder if we should avoid panicking here though - either return a default "", or bubble up?

fn get_current_working_dir() -> Result<PathBuf, io::Error> {
std::env::current_dir().or_else(|_| Ok(get_home_dir()))
}

[michaelneale]

yeah - in other cases if we can't find a cwd then default to home (I think that may only show up in rare testing scenarios though). Things will work if you run from home (as it is usually smart enough to then know what directory to really work in from context later on) - so seems reasonable to default instead of panic?

[s-soroosh]

Here we default to home dir and then panic. Isn't this the same behaviour as you outlined?
Note that get_home_dir itself also panic if it can't find the home dir. So I think the only question is whether want want to show a specific error here that cwd couldn't be determined, or home directory couldn't be determined.