fix: use current working directory as default for session metadata

[s-soroosh]

• Fixes Goose CLI: Working dir not properly set for new sessions #2790

Previously, when a session had no messages or an invalid working directory, it would default to the home directory. This changes the behavior to use the current working directory instead, which I think is more intuitive and matches user expectations.

Questions

• Is there any drawback to use cwd as the default working directory instead of home directory?

[michaelneale]

see comment by @DOsinga - looks interesting but I think has to be a default does't there? otherwise it will just fail

[s-soroosh]

@DOsinga @michaelneale Thanks for the reviews! Updated the code to fallback to home dir in case working directory cannot be determined

[michaelneale]

I think CWD make more sense @s-soroosh I like this, but not entirely clear how to test/reproduce, code reads fine, but do you have a scenario to test with?

[michaelneale]

@s-soroosh also will need DCO https://github.com/block/goose/pull/2793/checks?check_run_id=45675312414 it looks like but LGTM otherwise.

[michaelneale]

ie if you could show some samples of it working new way - then I think we are good to go with this for next release

[michaelneale]

actually DCO skipped, this needs to be udpated to main and should pass the build

[michaelneale]

@s-soroosh mind updating this to main branch again?

[michaelneale]

closing for now until more feedback

[nyonson]

Just curious what feedback is required for this patch? The issue is definitely a little painpoint in the CLI at the moment.

[s-soroosh]

Hey, I was busy this week and haven't found time yet to address the latest feedback.
It's mainly about rebasing my branch and write down a scenario to reproduce this issue and how this patch fixes it.
Will work on it later today or tomorrow.

[s-soroosh]

Reopened a PR with the same changes here.