Skip to content

Conversation

@vilcans
Copy link
Contributor

@vilcans vilcans commented Jul 8, 2025

While these messages, like "Calculating the meaning of life", are amusing, being amused can sometimes be distracting. I prefer the UI to be consistent so I don't waste time on reading text that's not relevant to what I'm trying to accomplish. This patch adds the setting RANDOM_THINKING_MESSAGES, default true, that when changed to false replaces those messages with the less amusing text: "Thinking..."

@lily-de
Copy link
Contributor

lily-de commented Jul 9, 2025

Thanks for the contribution! Before we merge this, I'd like to raise a broader concern about our approach to configuration flags.

We're accumulating various configuration options without a clear documentation strategy or governance process. This creates two key problems:

  1. Support burden: As maintainers, we can't effectively help users debug their setups when we're not aware of all possible configuration combinations and their interactions.
  2. Technical debt: Without proper tracking, we risk creating conflicting states or incompatible combinations that could cause issues down the line.

This specific flag is benign ofc, but for current and future configuration additions, I think we need to establish:

  • A centralized place to document all configuration options
  • Clear naming conventions
  • Documentation of expected behavior and any known interactions with other flags

cc @DOsinga

Copy link
Contributor

@lily-de lily-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great -- will approve after the docs get updated with information about how to use this variable here: https://github.com/block/goose/blob/main/documentation/docs/guides/environment-variables.md

@angiejones
Copy link
Collaborator

Thanks for the contribution! Before we merge this, I'd like to raise a broader concern about our approach to configuration flags.

We're accumulating various configuration options without a clear documentation strategy or governance process. This creates two key problems:

  1. Support burden: As maintainers, we can't effectively help users debug their setups when we're not aware of all possible configuration combinations and their interactions.
  2. Technical debt: Without proper tracking, we risk creating conflicting states or incompatible combinations that could cause issues down the line.

This specific flag is benign ofc, but for current and future configuration additions, I think we need to establish:

  • A centralized place to document all configuration options
  • Clear naming conventions
  • Documentation of expected behavior and any known interactions with other flags

cc @DOsinga

I added the variable to the Environment Variables guide

@angiejones angiejones requested a review from lily-de July 27, 2025 06:18
@angiejones angiejones dismissed lily-de’s stale review July 27, 2025 06:19

I addressed Lily's review comments

vilcans and others added 3 commits July 27, 2025 02:03
@angiejones angiejones merged commit 06a98e6 into block:main Jul 27, 2025
8 checks passed
michaelneale added a commit that referenced this pull request Jul 28, 2025
* main: (25 commits)
  fix: add maintainer, homepage and categories to DEB/RPM package config (#3096)
  blog: agent to agent convo (#3677)
  Possible to disable random thinking messages (#3304)
  Two VS code tutorials (#3603)
  small blog fixes (#3549)
  docs: fix installation command for YouTube Transcript MCP in servers.json (#3595)
  Docs for using Docker Model Runner as a local LLM provider.  (#3509)
  Docs: VS Code Extension move to tutorials (#3601)
  Fix working directory when session has no messages (#3513)
  goose docs MCP server (#3665)
  Remove confusing status output when testing sharing url connection and it shows 404 (#3659)
  chore: use typed notifications from rmcp (#3653)
  feat: convert GetPromptResult from mcp_core to rmcp version (#3650)
  feat: Replace usage of mcp_core Tools/ToolAnnotations in openapi schema (#3649)
  fix: ensure execution task result is shown (#3629)
  docs: Quick spotlight fix (#3633)
  alexhancock/rmcp-tools-annotations (#3617)
  fix: clean up subagent (#3565)
  Adds the `WaitingForUserInput` state (#3620)
  docs: update extensions library (#3612)
  ...
michaelneale added a commit that referenced this pull request Jul 28, 2025
* main: (27 commits)
  Add inline python extension (#3107)
  fix: add maintainer, homepage and categories to DEB/RPM package config (#3096)
  blog: agent to agent convo (#3677)
  Possible to disable random thinking messages (#3304)
  Two VS code tutorials (#3603)
  small blog fixes (#3549)
  docs: fix installation command for YouTube Transcript MCP in servers.json (#3595)
  Docs for using Docker Model Runner as a local LLM provider.  (#3509)
  Docs: VS Code Extension move to tutorials (#3601)
  Fix working directory when session has no messages (#3513)
  goose docs MCP server (#3665)
  Remove confusing status output when testing sharing url connection and it shows 404 (#3659)
  chore: use typed notifications from rmcp (#3653)
  feat: convert GetPromptResult from mcp_core to rmcp version (#3650)
  feat: Replace usage of mcp_core Tools/ToolAnnotations in openapi schema (#3649)
  fix: ensure execution task result is shown (#3629)
  docs: Quick spotlight fix (#3633)
  alexhancock/rmcp-tools-annotations (#3617)
  fix: clean up subagent (#3565)
  Adds the `WaitingForUserInput` state (#3620)
  ...
michaelneale added a commit that referenced this pull request Jul 28, 2025
* main: (69 commits)
  Add inline python extension (#3107)
  fix: add maintainer, homepage and categories to DEB/RPM package config (#3096)
  blog: agent to agent convo (#3677)
  Possible to disable random thinking messages (#3304)
  Two VS code tutorials (#3603)
  small blog fixes (#3549)
  docs: fix installation command for YouTube Transcript MCP in servers.json (#3595)
  Docs for using Docker Model Runner as a local LLM provider.  (#3509)
  Docs: VS Code Extension move to tutorials (#3601)
  Fix working directory when session has no messages (#3513)
  goose docs MCP server (#3665)
  Remove confusing status output when testing sharing url connection and it shows 404 (#3659)
  chore: use typed notifications from rmcp (#3653)
  feat: convert GetPromptResult from mcp_core to rmcp version (#3650)
  feat: Replace usage of mcp_core Tools/ToolAnnotations in openapi schema (#3649)
  fix: ensure execution task result is shown (#3629)
  docs: Quick spotlight fix (#3633)
  alexhancock/rmcp-tools-annotations (#3617)
  fix: clean up subagent (#3565)
  Adds the `WaitingForUserInput` state (#3620)
  ...
katzdave added a commit that referenced this pull request Jul 28, 2025
…cn/compact2-task-tracking

* 'dkatz/goose-compact2' of github.com:block/goose: (22 commits)
  rm stray files
  unused
  fmt
  fix threshold
  autocompact splice last message
  fmt
  Fix conversations before they hit the LLM (#3660)
  cli: add detailed instruction for WSL users (#3496)
  feat: recipe runs will now prompt for missing extension secrets (#3668)
  fix: pricing integration tests -> trying more runs for cache and retries (#3546)
  Add inline python extension (#3107)
  fix: add maintainer, homepage and categories to DEB/RPM package config (#3096)
  blog: agent to agent convo (#3677)
  Possible to disable random thinking messages (#3304)
  Two VS code tutorials (#3603)
  small blog fixes (#3549)
  docs: fix installation command for YouTube Transcript MCP in servers.json (#3595)
  Docs for using Docker Model Runner as a local LLM provider.  (#3509)
  Docs: VS Code Extension move to tutorials (#3601)
  Fix working directory when session has no messages (#3513)
  ...
michaelneale added a commit that referenced this pull request Jul 29, 2025
* dkatz/goose-compact2: (22 commits)
  rm stray files
  unused
  fmt
  fix threshold
  autocompact splice last message
  fmt
  Fix conversations before they hit the LLM (#3660)
  cli: add detailed instruction for WSL users (#3496)
  feat: recipe runs will now prompt for missing extension secrets (#3668)
  fix: pricing integration tests -> trying more runs for cache and retries (#3546)
  Add inline python extension (#3107)
  fix: add maintainer, homepage and categories to DEB/RPM package config (#3096)
  blog: agent to agent convo (#3677)
  Possible to disable random thinking messages (#3304)
  Two VS code tutorials (#3603)
  small blog fixes (#3549)
  docs: fix installation command for YouTube Transcript MCP in servers.json (#3595)
  Docs for using Docker Model Runner as a local LLM provider.  (#3509)
  Docs: VS Code Extension move to tutorials (#3601)
  Fix working directory when session has no messages (#3513)
  ...
atarantino pushed a commit to atarantino/goose that referenced this pull request Aug 5, 2025
Co-authored-by: angiejones <[email protected]>
Signed-off-by: Adam Tarantino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants