fix: handle JsonRPC error variants as responses #2903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingjiehe-xyz
approved these changes
Jun 13, 2025
opdich
added a commit
to opdich/goose
that referenced
this pull request
Jun 13, 2025
* upstream/main: Disable updater until we can debug more in release (block#2908) fix router trait error (block#2910) fix: Check for stderr error in receive() (block#2905) Damien/sagemaker tgi (block#2888) feat: (tool router) llm tool selector (block#2866) feat: (tool router) adds extension name in vector db & search tool (block#2855) Check for UPDATES_ENABLED flag before running update logic or in ui (block#2897) fix: handled the missing keyring error gracefully with a user-friendly message (block#2900) fix: handle JsonRPC error variants as responses (block#2903)
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
Signed-off-by: Soroosh <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the message handling block treated only JsonRpcMessage::JsonRpcResponse types with ids as request responses, and all other messages were sent to the notification stream. But, servers may send back a JsonRpcError which is distinct from JsonRpcResponse. This should not be sent to the notification stream.
Also added this to the integration test.
Fixes #2884