Skip to content

fix: handle JsonRPC error variants as responses #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yingjiehe-xyz merged 1 commit into from
Jun 13, 2025
Merged

fix: handle JsonRPC error variants as responses #2903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/mcp-client/examples/integration_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ where
let collected_events_after = events.lock().await.len();
assert_eq!(collected_events_after - collected_eventes_before, n_steps);

let error_result = client
.call_tool("add", serde_json::json!({ "a": "foo", "b": "bar" }))
.await;
assert!(error_result.is_err());
println!("Error result: {error_result:#?}\n");

// List resources
let resources = client.list_resources(None).await?;
println!("Resources: {resources:#?}\n");
Expand Down
3 changes: 2 additions & 1 deletion crates/mcp-client/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ where
Ok(message) => {
tracing::info!("Received message: {:?}", message);
match message {
JsonRpcMessage::Response(JsonRpcResponse { id: Some(id), .. }) => {
JsonRpcMessage::Response(JsonRpcResponse { id: Some(id), .. })
| JsonRpcMessage::Error(JsonRpcError { id: Some(id), .. }) => {
service_ptr.respond(&id.to_string(), Ok(message)).await;
}
_ => {
Expand Down
Loading