Skip to content

Conversation

@yingjiehe-xyz
Copy link
Contributor

@yingjiehe-xyz yingjiehe-xyz commented Jun 13, 2025

Fix the error:

error[E0050]: method `index_tools` has 2 parameters but the declaration in trait `RouterToolSelector::index_tools` has 3
   --> crates/goose/src/agents/router_tool_selector.rs:285:26
    |
28  |     async fn index_tools(&self, tools: &[Tool], extension_name: &str) -> Result<(), ToolError>;
    |                          ------------------------------------------- trait requires 3 parameters
...
285 |     async fn index_tools(&self, tools: &[Tool]) -> Result<(), ToolError> {
    |                          ^^^^^^^^^^^^^^^^^^^^^ expected 3 parameters, found 2

For more information about this error, try `rustc --explain E0050`.

@yingjiehe-xyz yingjiehe-xyz requested a review from wendytang June 13, 2025 18:33
@yingjiehe-xyz yingjiehe-xyz merged commit fe16789 into main Jun 13, 2025
7 checks passed
@yingjiehe-xyz yingjiehe-xyz deleted the yingjiehe/router branch June 13, 2025 18:53
opdich added a commit to opdich/goose that referenced this pull request Jun 13, 2025
* upstream/main:
  Disable updater until we can debug more in release (block#2908)
  fix router trait error (block#2910)
  fix: Check for stderr error in receive() (block#2905)
  Damien/sagemaker tgi (block#2888)
  feat: (tool router) llm tool selector (block#2866)
  feat: (tool router) adds extension name in vector db & search tool (block#2855)
  Check for UPDATES_ENABLED flag before running update logic or in ui (block#2897)
  fix: handled the missing keyring error gracefully with a user-friendly message (block#2900)
  fix: handle JsonRPC error variants as responses (block#2903)
emma-squared pushed a commit that referenced this pull request Jun 13, 2025
zanesq added a commit that referenced this pull request Jun 13, 2025
* 'main' of github.com:block/goose:
  Disable updater until we can debug more in release (#2908)
  fix router trait error (#2910)
  fix: Check for stderr error in receive() (#2905)
  Damien/sagemaker tgi (#2888)
  feat: (tool router) llm tool selector (#2866)
  feat: (tool router) adds extension name in vector db & search tool (#2855)
michaelneale added a commit that referenced this pull request Jun 16, 2025
* main: (51 commits)
  Docs: Fetch MCP doesnt work with Gemini (#2940)
  feat: add Help & Feedback section in App Settings (#2935)
  docs: blog update (#2937)
  docs: fixing blog image (#2936)
  docs: lead/worker tutorial and blog post (#2930)
  chore(deps): bump golang.org/x/net from 0.14.0 to 0.38.0 in /temporal-service (#2836)
  chore(deps): bump google.golang.org/grpc from 1.57.0 to 1.57.1 in /temporal-service (#2834)
  fix updater download text (#2919)
  chore(release): release version 1.0.28 (#2906)
  Enable updater and remove unzipping and installing update text (#2918)
  docs: updates for lead-worker model (#2916)
  fix: correct spelling in error messages and documentation (#2840)
  Change updater to use platform agnostic and secure zip library (#2913)
  Docs: Edit recipes on Goose desktop (#2912)
  Disable updater until we can debug more in release (#2908)
  fix router trait error (#2910)
  fix: Check for stderr error in receive() (#2905)
  Damien/sagemaker tgi (#2888)
  feat: (tool router) llm tool selector (#2866)
  feat: (tool router) adds extension name in vector db & search tool (#2855)
  ...
lifeizhou-ap added a commit that referenced this pull request Jun 16, 2025
* main: (23 commits)
  Docs: Fetch MCP doesnt work with Gemini (#2940)
  feat: add Help & Feedback section in App Settings (#2935)
  docs: blog update (#2937)
  docs: fixing blog image (#2936)
  docs: lead/worker tutorial and blog post (#2930)
  chore(deps): bump golang.org/x/net from 0.14.0 to 0.38.0 in /temporal-service (#2836)
  chore(deps): bump google.golang.org/grpc from 1.57.0 to 1.57.1 in /temporal-service (#2834)
  fix updater download text (#2919)
  chore(release): release version 1.0.28 (#2906)
  Enable updater and remove unzipping and installing update text (#2918)
  docs: updates for lead-worker model (#2916)
  fix: correct spelling in error messages and documentation (#2840)
  Change updater to use platform agnostic and secure zip library (#2913)
  Docs: Edit recipes on Goose desktop (#2912)
  Disable updater until we can debug more in release (#2908)
  fix router trait error (#2910)
  fix: Check for stderr error in receive() (#2905)
  Damien/sagemaker tgi (#2888)
  feat: (tool router) llm tool selector (#2866)
  feat: (tool router) adds extension name in vector db & search tool (#2855)
  ...
s-soroosh pushed a commit to s-soroosh/goose that referenced this pull request Jul 18, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants