fix: handled the missing keyring error gracefully with a user-friendly message #2900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| output::render_error(&format!( | ||
| "Error {}.\n\ | ||
| Please check your system keychain and run 'goose configure' again.\n\ | ||
| If your system is unable to use the keyring, please try setting secret key(s) via environment variables.\n\ |
Contributor
There was a problem hiding this comment.
can we check the error here? the error may not be related to keyring
Contributor
Author
There was a problem hiding this comment.
If you go the goose doc link I attached in the PR description, you can see the error I got when I ran goose session without api key configured as an ent variable is the same as what they mentioned in the doc.
It is just that the actual error message is fuzzier than what it is supposed to be.
yingjiehe-xyz
approved these changes
Jun 13, 2025
opdich
added a commit
to opdich/goose
that referenced
this pull request
Jun 13, 2025
* upstream/main: Disable updater until we can debug more in release (block#2908) fix router trait error (block#2910) fix: Check for stderr error in receive() (block#2905) Damien/sagemaker tgi (block#2888) feat: (tool router) llm tool selector (block#2866) feat: (tool router) adds extension name in vector db & search tool (block#2855) Check for UPDATES_ENABLED flag before running update logic or in ui (block#2897) fix: handled the missing keyring error gracefully with a user-friendly message (block#2900) fix: handle JsonRPC error variants as responses (block#2903)
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
…y message (block#2900) Signed-off-by: Soroosh <[email protected]>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves error handling in the
build_sessionfunction of thegoose-clicrate. Specifically, it replaces anunwrapcall with a more robust error-handling mechanism to provide user-friendly error messages and guidance.Error handling improvements:
build_sessionfunction incrates/goose-cli/src/session/builder.rsto replace theunwrapcall with amatchstatement. This change ensures that errors during the creation of a provider are caught and handled gracefully. If an error occurs, a detailed error message is displayed, including troubleshooting steps and a link to relevant documentation, before the process exits with a non-zero status.Details:
The error message displayed when no keyring is found is different from what the goose doc mentioned. It currently looked like this (Display
thread 'main' panicked....is kinda off to users I think, since this message is intended for developers and exposes internal file paths and implementation details that are confusing or irrelevant to end users.)I made the system handle the error gracefully and display a user-friendly message with reference to the troubleshooting session to the goose doc.