feat: enable smart approve for user by default #1599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingjiehe-xyz
changed the title
Contributor
|
wendytang
reviewed
Mar 10, 2025
| ::: | ||
|
|
||
| </TabItem> | ||
| </Tabs> |
There was a problem hiding this comment.
could we keep a note here explaining 'Read Write approve' -
goose will only ask for permission before tool call for tools that it deems are 'write' tools, for example any 'text editor write', 'text editor edit', 'bash - rm, cp, mv' commands, as an example. Read write approval makes best effort attempt at classifying read or write tools- this is interpreted by your LLM provider.
wendytang
reviewed
Mar 10, 2025
| value: 'approve', | ||
| label: 'Approval needed', | ||
| description: 'Editing, creating, and deleting files will require human approval.', | ||
| description: |
There was a problem hiding this comment.
'Classifies the tool as either a read-only tool or write tool. Write tools will ask for human approval'
wendytang
suggested changes
Mar 10, 2025
wendytang
left a comment
wendytang
left a comment
There was a problem hiding this comment.
I would still prefer to veer away from 'smart' 'intelligent' - the truth is we are just asking for write permission. If it were truly learned, then we could call it 'smart', but there is no learning here
Contributor
Author
make sense, refresh the doc |
michaelneale
added a commit
that referenced
this pull request
Mar 11, 2025
* main: feat: enable smart approve for user by default (#1599) ui: fix modal state (#1598) ui: setting configuration (#1597) fix: merge error logging in goose bench (#1545) feat: add additional goosebench evals (#1571) chore: update types and imports (#1594) Retain session through view changes (#1580) docs: Add steps for desktop tutorial (#1590) remove env vars from bottom menu model setting (#1584) Fix Goosehints modal UI (#1581) docs: typo fix (#1593) feat: update config endpoints for use with providers (#1563) fix: update anthropic provider headers (#1592) feat: Build Goose in a Docker Container (#1551) docs: voyp blog post (#1588)
sheagcraig
added a commit
to sheagcraig/goose
that referenced
this pull request
Mar 11, 2025
* upstream/main: (48 commits) feat: enable smart approve for user by default (block#1599) ui: fix modal state (block#1598) ui: setting configuration (block#1597) fix: merge error logging in goose bench (block#1545) feat: add additional goosebench evals (block#1571) chore: update types and imports (block#1594) Retain session through view changes (block#1580) docs: Add steps for desktop tutorial (block#1590) remove env vars from bottom menu model setting (block#1584) Fix Goosehints modal UI (block#1581) docs: typo fix (block#1593) feat: update config endpoints for use with providers (block#1563) fix: update anthropic provider headers (block#1592) feat: Build Goose in a Docker Container (block#1551) docs: voyp blog post (block#1588) fix: included files was panicing because dir didnt exist (block#1583) feat: work with docs/xls and simple html (block#1526) feat: parallel processing in approve mode (block#1575) Feat: support auto-including dirs in binary/bench-work-dir (block#1576) refactor models component (block#1535) ...
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable smart approve for user by default and no need the experiment control
Test:
