Skip to content

ui: fix modal state #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lily-de merged 3 commits into from
Mar 11, 2025
Merged

ui: fix modal state #1598

lily-de merged 3 commits into from
Mar 11, 2025

Conversation

@lily-de
Copy link
Contributor

@lily-de lily-de commented Mar 10, 2025

Had some weird statefulness where

  1. enter a value into the form
  2. submit -- all good, yay
  3. without closing page, open form again
  4. can see your entered value
  5. close the settings page or start new session
  6. look at settings again, provider still configured BUT form value has reverted to the default, which is confusing

Now we load non-secret values into the form if you have them set, if you don't the form will contain the default

@lily-de
Copy link
Contributor Author

lily-de commented Mar 10, 2025

Screen.Recording.2025-03-10.at.2.34.10.PM.mov

@lily-de lily-de merged commit eb5b296 into main Mar 11, 2025
6 checks passed
@lily-de lily-de deleted the ldelalande/fix-modal-state branch March 11, 2025 00:07
michaelneale added a commit that referenced this pull request Mar 11, 2025
@michaelneale
Merge branch 'main' into micn/google-sheets
972a852 
* main:
  feat: enable smart approve for user by default (#1599)
  ui: fix modal state (#1598)
  ui: setting configuration (#1597)
  fix: merge error logging in goose bench  (#1545)
  feat: add additional goosebench evals (#1571)
  chore: update types and imports (#1594)
  Retain session through view changes (#1580)
  docs: Add steps for desktop tutorial (#1590)
  remove env vars from bottom menu model setting (#1584)
  Fix Goosehints modal UI (#1581)
  docs: typo fix (#1593)
  feat: update config endpoints for use with providers (#1563)
  fix: update anthropic provider headers (#1592)
  feat: Build Goose in a Docker Container (#1551)
  docs: voyp blog post (#1588)
sheagcraig added a commit to sheagcraig/goose that referenced this pull request Mar 11, 2025
@sheagcraig
Merge remote-tracking branch 'upstream/main' into gdrive-write
3d05f69 
* upstream/main: (48 commits)
  feat: enable smart approve for user by default (block#1599)
  ui: fix modal state (block#1598)
  ui: setting configuration (block#1597)
  fix: merge error logging in goose bench  (block#1545)
  feat: add additional goosebench evals (block#1571)
  chore: update types and imports (block#1594)
  Retain session through view changes (block#1580)
  docs: Add steps for desktop tutorial (block#1590)
  remove env vars from bottom menu model setting (block#1584)
  Fix Goosehints modal UI (block#1581)
  docs: typo fix (block#1593)
  feat: update config endpoints for use with providers (block#1563)
  fix: update anthropic provider headers (block#1592)
  feat: Build Goose in a Docker Container (block#1551)
  docs: voyp blog post (block#1588)
  fix: included files was panicing because dir didnt exist (block#1583)
  feat: work with docs/xls and simple html (block#1526)
  feat: parallel processing in approve mode (block#1575)
  Feat: support auto-including dirs in binary/bench-work-dir (block#1576)
  refactor models component (block#1535)
  ...
ahau-square pushed a commit that referenced this pull request May 2, 2025
@lily-de
ui: fix modal state (#1598)
d90881d
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
@lily-de
ui: fix modal state (block#1598)
3e35d65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalvinnchau kalvinnchau kalvinnchau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lily-de @kalvinnchau