Retain session through view changes #1580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ This worked for me when to go Settings and then Back, or if I go to Previous Sessions and then Back. ❌ "Resume Session" fails for me: https://github.com/user-attachments/assets/1c4b03de-792c-4693-b5d3-9863e4ba00f8 |
salman1993
requested changes
Mar 10, 2025
Contributor
salman1993
left a comment
salman1993
left a comment
There was a problem hiding this comment.
Resuming session hangs for me from SessionHistoryView
Contributor
Author
|
@salman1993 |
salman1993
reviewed
Mar 10, 2025
michaelneale
added a commit
that referenced
this pull request
Mar 11, 2025
* main: feat: enable smart approve for user by default (#1599) ui: fix modal state (#1598) ui: setting configuration (#1597) fix: merge error logging in goose bench (#1545) feat: add additional goosebench evals (#1571) chore: update types and imports (#1594) Retain session through view changes (#1580) docs: Add steps for desktop tutorial (#1590) remove env vars from bottom menu model setting (#1584) Fix Goosehints modal UI (#1581) docs: typo fix (#1593) feat: update config endpoints for use with providers (#1563) fix: update anthropic provider headers (#1592) feat: Build Goose in a Docker Container (#1551) docs: voyp blog post (#1588)
sheagcraig
added a commit
to sheagcraig/goose
that referenced
this pull request
Mar 11, 2025
* upstream/main: (48 commits) feat: enable smart approve for user by default (block#1599) ui: fix modal state (block#1598) ui: setting configuration (block#1597) fix: merge error logging in goose bench (block#1545) feat: add additional goosebench evals (block#1571) chore: update types and imports (block#1594) Retain session through view changes (block#1580) docs: Add steps for desktop tutorial (block#1590) remove env vars from bottom menu model setting (block#1584) Fix Goosehints modal UI (block#1581) docs: typo fix (block#1593) feat: update config endpoints for use with providers (block#1563) fix: update anthropic provider headers (block#1592) feat: Build Goose in a Docker Container (block#1551) docs: voyp blog post (block#1588) fix: included files was panicing because dir didnt exist (block#1583) feat: work with docs/xls and simple html (block#1526) feat: parallel processing in approve mode (block#1575) Feat: support auto-including dirs in binary/bench-work-dir (block#1576) refactor models component (block#1535) ...
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1532
Currently, chat messages are stored in the Chat View. So, if you navigate away from the Chat View (such as to Settings), the chat messages are lost.
This PR:
useChat(). There was a few different files in which messages we being loaded/reloaded, and now it all happens here. This also allows for some refactoring and simplifying.chatis now where both themessagesandid(aka session id) now live. It might be a good idea to combine this with theuseMessageStream()hook, given that they share a bit of responsibility and are mildly stepping on each other's toes.