Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Doc bevy sprite #7858

Closed
wants to merge 16 commits into from
Closed

[Merged by Bors] - Doc bevy sprite #7858

wants to merge 16 commits into from

Conversation

shuoli84
Copy link
Contributor

@shuoli84 shuoli84 commented Mar 1, 2023

Add doc for several pub items. Remove dead code and minor changes.

@alice-i-cecile
Copy link
Member

Just a couple suggested improvements, but this definitely seems better to me.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen labels Mar 1, 2023
ickshonpe
ickshonpe reviewed Mar 1, 2023
View reviewed changes
crates/bevy_sprite/src/bundle.rs Outdated Show resolved Hide resolved
crates/bevy_sprite/src/texture_atlas.rs Outdated Show resolved Hide resolved
@shuoli84 shuoli84 requested review from alice-i-cecile and ickshonpe and removed request for alice-i-cecile and ickshonpe March 2, 2023 00:17
@shuoli84
Copy link
Contributor Author

shuoli84 commented Mar 2, 2023

Hmm, seems I don't quite understand how "request review" works. LOL

ickshonpe
ickshonpe suggested changes Mar 2, 2023
View reviewed changes
crates/bevy_sprite/src/texture_atlas.rs Outdated Show resolved Hide resolved
crates/bevy_sprite/src/texture_atlas.rs Outdated Show resolved Hide resolved
crates/bevy_sprite/src/texture_atlas.rs Show resolved Hide resolved
crates/bevy_sprite/src/texture_atlas.rs Outdated Show resolved Hide resolved
crates/bevy_sprite/src/texture_atlas.rs Outdated Show resolved Hide resolved
crates/bevy_sprite/src/texture_atlas.rs Show resolved Hide resolved
crates/bevy_sprite/src/texture_atlas.rs Outdated Show resolved Hide resolved
@ickshonpe
Copy link
Contributor

ickshonpe commented Mar 2, 2023 •
edited
Loading

Just a couple more minor nitpicks, then looks good.

@shuoli84
Copy link
Contributor Author

shuoli84 commented Mar 3, 2023

ping

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 3, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 3, 2023
@shuoli84
Doc bevy sprite (#7858)
47ddd4a 
Add doc for several pub items. Remove dead code and minor changes.
@bors
Copy link
Contributor

bors bot commented Mar 3, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Doc bevy sprite [Merged by Bors] - Doc bevy sprite Mar 3, 2023
@bors bors bot closed this Mar 3, 2023
@shuoli84 shuoli84 deleted the doc_bevy_sprite branch March 4, 2023 13:23
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@shuoli84 @Shfty
Doc bevy sprite (bevyengine#7858)
f1517e9 
Add doc for several pub items. Remove dead code and minor changes.
@samyduc samyduc mentioned this pull request May 19, 2023
Closed
@james7132 james7132 mentioned this pull request May 21, 2023
Merged
@james7132 james7132 added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label May 21, 2023
@github-actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vrixyz Vrixyz Vrixyz approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@ickshonpe ickshonpe ickshonpe approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shuoli84 @alice-i-cecile @ickshonpe @Vrixyz @james7132