Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The field texture_handles in TextureAtlas changed visibility making the struct non instantiable from Game Code #8633

Closed
samyduc opened this issue May 19, 2023 · 0 comments · Fixed by #8643
Closed

The field texture_handles in TextureAtlas changed visibility making the struct non instantiable from Game Code #8633

samyduc opened this issue May 19, 2023 · 0 comments · Fixed by #8643
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this!

Comments

@samyduc
Copy link

samyduc commented May 19, 2023

Bevy version

0.10.0

I have a custom Texture Packer for sprite animation in 3d space (so not using the sprite crate or 2d rendering). It heavily uses the struct TextureAtlas.
Sadly, 2 months ago, the change #7858 changed the visibility of one of the field (texture_handles) from pub to pub(crate).

Therefor I cannot instantiate this struct from my program anymore. I know there is the TextureAtlasBuilder (maybe it would solve my use case) but it is a bit of shame to not be able to access this class directly just for no apparent reason (and because of a side effect of a doc change).

Can we switch it back to pub?
@samyduc samyduc added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels May 19, 2023
@nicopap nicopap added A-Rendering Drawing game state to the screen P-Regression Functionality that used to work but no longer does. Add a test for this! and removed S-Needs-Triage This issue needs to be labelled labels May 19, 2023
adtennant added a commit to adtennant/bevy that referenced this issue May 20, 2023
@adtennant
Make TextureAtlas::texture_handles pub instead of pub(crate) (b…
70cf676 
…evyengine#8633)

# Objective

- Fixes bevyengine#8633

## Solution

Make `TextureAtlas::texture_handles` `pub` instead of `pub(crate)`.
This was referenced May 20, 2023
Closed
Merged
@alice-i-cecile alice-i-cecile mentioned this issue May 20, 2023
Merged
@adtennant adtennant mentioned this issue May 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this!
Projects
None yet
Milestone
No milestone
2 participants
@samyduc @nicopap