Added basic mouse capture API #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karroffel
added
C-Feature
|
This definitely works, but for consistency I think we should port this to using the getters/setters introduced in this pr: #644 (which we just merged) |
|
Looks like you accidentally added new versions some past commits. I fixed this by rebasing on master. Not really a huge deal either way because we squash+merge every pr, but the rebase made it slightly easier to review / removed a bunch of unnecessary participants. |
cart
reviewed
Oct 16, 2020
crates/bevy_winit/src/lib.rs
Outdated
| @@ -296,3 +313,36 @@ fn handle_create_window_events( | |||
| window_created_events.send(WindowCreated { id: window_id }); | |||
| } | |||
| } | |||
|
|
|||
| fn handle_cursor_state_change_events( | |||
There was a problem hiding this comment.
I don't think we need these events anymore. I'd prefer the Window getters/setters to be the one way to set these things
Closed
Closed
joshuajbouw
pushed a commit
to joshuajbouw/bevy
that referenced
this pull request
Oct 24, 2020
Added basic cursor lock API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #642.