Skip to content

bevy_winit: Create the window initially invisible as required by AccessKit #18346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

bevy_winit: Create the window initially invisible as required by AccessKit #18346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0994a56
bevy_winit: Create the window initially invisible as required by Acce…
mwcampbell Mar 16, 2025
83105d7
Add comments
mwcampbell Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/bevy_winit/src/winit_windows.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,16 @@ impl WinitWindows {
}
};

// It's crucial to avoid setting the window's final visibility here;
// as explained above, the window must be invisible until the AccessKit
// adapter is created.
winit_window_attributes = winit_window_attributes
.with_window_level(convert_window_level(window.window_level))
.with_theme(window.window_theme.map(convert_window_theme))
.with_resizable(window.resizable)
.with_enabled_buttons(convert_enabled_buttons(window.enabled_buttons))
.with_decorations(window.decorations)
.with_transparent(window.transparent)
.with_visible(window.visible);
.with_transparent(window.transparent);

#[cfg(target_os = "windows")]
{
Expand Down Expand Up @@ -284,6 +286,10 @@ impl WinitWindows {
handlers,
);

// Now that the AccessKit adapter is created, it's safe to show
// the window.
winit_window.set_visible(window.visible);

// Do not set the grab mode on window creation if it's none. It can fail on mobile.
if window.cursor_options.grab_mode != CursorGrabMode::None {
let _ = attempt_grab(&winit_window, window.cursor_options.grab_mode);
Expand Down