Skip to content

bevy_winit: Create the window initially invisible as required by AccessKit #18346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2025
Merged

bevy_winit: Create the window initially invisible as required by AccessKit #18346

merged 2 commits into from
Mar 17, 2025

Conversation

@mwcampbell
Copy link
Contributor

@mwcampbell mwcampbell commented Mar 16, 2025

The initial with_visible call was intended to do this, but that was undone by a later with_visible call.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2025

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Windowing Platform-agnostic interface layer to run your app in A-Accessibility A problem that prevents users with disabilities from using Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 16, 2025
alice-i-cecile
alice-i-cecile requested changes Mar 16, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your judgement on the importance here, but can you add a comment to the set_visible line explaining why this is needed? It's not immediately apparent, and I'm worried about accidentally reverting this if there's no comment there :)

@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Mar 16, 2025
@mwcampbell
Copy link
Contributor Author

mwcampbell commented Mar 16, 2025

OK, now there are a total of three comments (the first one was already there).

alice-i-cecile
alice-i-cecile approved these changes Mar 16, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you so much.

@mwcampbell
Copy link
Contributor Author

mwcampbell commented Mar 16, 2025

I don't seem to have permission to merge this. Or are we waiting for another review?

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Mar 16, 2025

Waiting for a second approval, then I'll merge it. This will make it into 0.16 though: it's in the milestone.

@mockersf mockersf added this pull request to the merge queue Mar 17, 2025
Merged via the queue into bevyengine:main with commit 3552674 Mar 17, 2025
31 checks passed
@ndarilek ndarilek mentioned this pull request Mar 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees

No one assigned

Labels

A-Accessibility A problem that prevents users with disabilities from using Bevy A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

0.16

Development

Successfully merging this pull request may close these issues.

3 participants

@mwcampbell @alice-i-cecile @mockersf