Allow registering boxed systems #10378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
approved these changes
Nov 5, 2023
inodentry
approved these changes
Nov 6, 2023
JoJoJet
added
the
S-Ready-For-Final-Review
cart
pushed a commit
that referenced
this pull request
Nov 30, 2023
# Objective - Allow registration of one-shot systems when those systems have already been `Box`ed. - Needed for `bevy_eventlisteners` which allows adding event listeners with callbacks in normal systems. The current one shot system implementation requires systems be registered from an exclusive system, and that those systems be passed in as types that implement `IntoSystem`. However, the eventlistener callback crate allows users to define their callbacks in normal systems, by boxing the system and deferring initialization to an exclusive system. ## Solution - Separate the registration of the system from the boxing of the system. This is non-breaking, and adds a new method. --- ## Changelog - Added `World::register_boxed_system` to allow registration of already-boxed one shot systems.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - Allow registration of one-shot systems when those systems have already been `Box`ed. - Needed for `bevy_eventlisteners` which allows adding event listeners with callbacks in normal systems. The current one shot system implementation requires systems be registered from an exclusive system, and that those systems be passed in as types that implement `IntoSystem`. However, the eventlistener callback crate allows users to define their callbacks in normal systems, by boxing the system and deferring initialization to an exclusive system. ## Solution - Separate the registration of the system from the boxing of the system. This is non-breaking, and adds a new method. --- ## Changelog - Added `World::register_boxed_system` to allow registration of already-boxed one shot systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Boxed.bevy_eventlistenerswhich allows adding event listeners with callbacks in normal systems. The current one shot system implementation requires systems be registered from an exclusive system, and that those systems be passed in as types that implementIntoSystem. However, the eventlistener callback crate allows users to define their callbacks in normal systems, by boxing the system and deferring initialization to an exclusive system.Solution
Changelog
World::register_boxed_systemto allow registration of already-boxed one shot systems.