-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.13: One-Shot system Improvements #909
0.13: One-Shot system Improvements #909
Conversation
I think Nathan Fenner is the right call for who to credit there: the other PRs are pretty incidental. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few small notes.
From the technical side, I think it's cool that run_system(id)
is now just the same as run_system_with_,input(id, ())
- bevy's generic types are quite magically expressive. It is a testament to Bevy's leveraging of Rust's type system just now easy this was to implement.
} | ||
|
||
let mut world = World::new(); | ||
let id = world.register_system(increment_sys); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type of id
is slightly different now, it's a SystemId<i32, i32>
, (though plain SystemId
still works and now means SystemId<(), ()>
) which might be worth mentioning- possibly also making the in/out types different in the example to clearly show which is which.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of brevity, I think I'll leave it out of the main post, but I like the idea of adding type annotations and maybe a comment to the code example. I'll do that later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a writer's standpoint this is good in grammar, readability, and being understandable other than what Nathan has already brought up.
Co-authored-by: Alice Cecile <[email protected]>
For the release notes (#891).
@Nathan-Fenner, I'd love it if you could proofread the text (if you have the time) and let me know if everything is correct.
I have kept it purposefully short, as I don't see it as a particularly big change, just some QOL.
Also, I don't quite know who to credit. I'm currently referring to changes done in
World::run_system
to get system output bevy#10380 (significant work)and I've only really given credit to Nathan Fenner so far, as that amounts to the lion's share of the work.