Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2d_shapes and general 2D mesh instancing #10051

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Fix 2d_shapes and general 2D mesh instancing #10051

merged 1 commit into from
Oct 8, 2023

Conversation

superdump
Copy link
Contributor

Objective

Solution

  • Push constants needed to be defined in the pipeline layout and bevy_sprite needed to have a webgl feature.

@superdump superdump added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen P-Regression Functionality that used to work but no longer does. Add a test for this! labels Oct 8, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 8, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 8, 2023
Merged via the queue into bevyengine:main with commit b6286cf Oct 8, 2023
29 of 30 checks passed
regnarock pushed a commit to regnarock/bevy that referenced this pull request Oct 13, 2023
@superdump
Fix 2d_shapes and general 2D mesh instancing (bevyengine#10051)
7c8b9c9 
# Objective

- Fix bevyengine#10050 

## Solution

- Push constants needed to be defined in the pipeline layout and
`bevy_sprite` needed to have a `webgl` feature.
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@superdump @ameknite
Fix 2d_shapes and general 2D mesh instancing (bevyengine#10051)
c0047cb 
- Fix bevyengine#10050

- Push constants needed to be defined in the pipeline layout and
`bevy_sprite` needed to have a `webgl` feature.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@superdump
Fix 2d_shapes and general 2D mesh instancing (bevyengine#10051)
d9562d3 
# Objective

- Fix bevyengine#10050 

## Solution

- Push constants needed to be defined in the pipeline layout and
`bevy_sprite` needed to have a `webgl` feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2d_shapes example does not render correctly in WebGL2
3 participants
@superdump @mockersf @alice-i-cecile