Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2d_shapes example does not render correctly in WebGL2 #10050

Closed
DGriffin91 opened this issue Oct 8, 2023 · 0 comments · Fixed by #10051
Closed

2d_shapes example does not render correctly in WebGL2 #10050

DGriffin91 opened this issue Oct 8, 2023 · 0 comments · Fixed by #10051
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior O-WebGL2 Specific to the WebGL2 render API P-Regression Functionality that used to work but no longer does. Add a test for this!
Milestone
0.12

Comments

@DGriffin91
Copy link
Contributor

Bevy version e67d63a

The issue was introduced at 5c884c5 with #9685.

[Optional] Relevant system information

Windows 10, RTX 3060

What you did

Run 2d_shapes example in the browser.

What went wrong

Mesh transforms are not correct.
image
@DGriffin91 DGriffin91 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Oct 8, 2023
@mockersf mockersf added this to the 0.12 milestone Oct 8, 2023
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen P-Regression Functionality that used to work but no longer does. Add a test for this! O-WebGL2 Specific to the WebGL2 render API and removed S-Needs-Triage This issue needs to be labelled labels Oct 8, 2023
@superdump superdump mentioned this issue Oct 8, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 8, 2023
@superdump
Fix 2d_shapes and general 2D mesh instancing (#10051)
b6286cf 
# Objective

- Fix #10050 

## Solution

- Push constants needed to be defined in the pipeline layout and
`bevy_sprite` needed to have a `webgl` feature.
regnarock pushed a commit to regnarock/bevy that referenced this issue Oct 13, 2023
@superdump
Fix 2d_shapes and general 2D mesh instancing (bevyengine#10051)
7c8b9c9 
# Objective

- Fix bevyengine#10050 

## Solution

- Push constants needed to be defined in the pipeline layout and
`bevy_sprite` needed to have a `webgl` feature.
ameknite pushed a commit to ameknite/bevy that referenced this issue Nov 6, 2023
@superdump @ameknite
Fix 2d_shapes and general 2D mesh instancing (bevyengine#10051)
c0047cb 
- Fix bevyengine#10050

- Push constants needed to be defined in the pipeline layout and
`bevy_sprite` needed to have a `webgl` feature.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this issue Jan 9, 2024
@superdump
Fix 2d_shapes and general 2D mesh instancing (bevyengine#10051)
d9562d3 
# Objective

- Fix bevyengine#10050 

## Solution

- Push constants needed to be defined in the pipeline layout and
`bevy_sprite` needed to have a `webgl` feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior O-WebGL2 Specific to the WebGL2 render API P-Regression Functionality that used to work but no longer does. Add a test for this!
Projects
None yet
Milestone
0.12
Development

Successfully merging a pull request may close this issue.

Fix 2d_shapes and general 2D mesh instancing superdump/bevy
3 participants
@alice-i-cecile @mockersf @DGriffin91