chore: Use peerDependencies marked as optional #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugin: puppeteer-extra
|
|
@rtritto yarn canary seems to be happy now 😄 yarn init -y
success Saved package.json
✨ Done in 0.06s.
yarn set version canary
➤ YN0000: Retrieving https://repo.yarnpkg.com/4.0.0-rc.11/packages/yarnpkg-cli/bin/yarn.js
➤ YN0000: Saving the new release in .yarn/releases/yarn-4.0.0-rc.11.cjs
➤ YN0000: Done in 1s 295ms
yarn add puppeteer [email protected] [email protected]
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed in 4s 246ms
➤ YN0000: ┌ Fetch step
➤ YN0013: │ webidl-conversions@npm:3.0.1 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ whatwg-url@npm:5.0.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ wrappy@npm:1.0.2 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ ws@npm:8.8.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ yauzl@npm:2.10.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0000: └ Completed in 4s 182ms
➤ YN0000: ┌ Link step
➤ YN0007: │ puppeteer@npm:15.3.1 must be built because it never has been before or the last one failed
➤ YN0000: └ Completed in 26s 186ms
➤ YN0000: Done in 34s 656ms |
This was referenced Jul 7, 2022
In this PR? Can't see them 🤔 |
|
Yes, you can check comments or changed files. |
yarn add [email protected]
➤ YN0000: ┌ Resolution step
➤ YN0000: └ Completed in 8s 848ms
➤ YN0000: ┌ Fetch step
➤ YN0013: │ puppeteer-extra-plugin-adblocker@npm:2.13.2 can't be found in the cache and will be fetched from the remote registry
➤ YN0000: └ Completed in 0s 401ms
➤ YN0000: ┌ Link step
➤ YN0000: └ Completed
➤ YN0000: Done in 9s 339ms |
|
@berstend Reviews:
packages/playwright-extra/package.json: "peerDependencies": {
"playwright": "*",
"playwright-core": "*"
- },
- "peerDependenciesMeta": {
- "playwright": {
- "optional": true
- },
- "playwright-core": {
- "optional": true
- }
}
packages/puppeteer-extra/package.json: "peerDependencies": {
"puppeteer": "*",
"puppeteer-core": "*",
- "@types/puppeteer": "*"
},
"peerDependenciesMeta": {
"puppeteer": {
"optional": true
},
"puppeteer-core": {
"optional": true
- },
- "@types/puppeteer": {
- "optional": true
- }
}, |
is this a hypothetical discussion or are there some issues currently? |
|
@berstend thanks for answers.
I don't know, for me there are no open points. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #527, #645, #672, #587
peerDependenciesMetawithoptional: trueis supported in yarn for a good while now and starting in npm v7In addition our plugins have a transitive peer dependency on
puppeteer-extra/playwright-extrathroughpuppeteer-extra-pluginwhich apparently needs to be specified directly in each plugin for package managers to be happyMore context around this can be found in this comment: #527 (comment)
References: