-
-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Use puppeteer-core as peer dependency instead of puppeteer #527
Comments
@berstend Bump |
Related discussion: #645 Given we now have playwright-extra as well being able to load puppeteer-extra plugins the best way seems to be using peer dependencies but marking all of them optional |
As initially suggested by @rtritto, adapting to our situation a solution could look like this: All puppeteer-extra plugins (base plugin as well) get: "peerDependencies": {
"puppeteer-extra": "*",
"playwright-extra": "*",
},
"peerDependenciesMeta": {
"puppeteer-extra": {
"optional": true
},
"playwright-extra": {
"optional": true
}
} (I don't think we can model an "either/or" thing here, so both optional seems like the best option)
|
Just for context: both So it makes sense to not force either of those as a hard dependency. Also both frameworks will throw at runtime in case the default exports are used and no respective launcher package is found |
Fixed in |
puppeteer-core package is a version of Puppeteer that doesn't download any browser by default.
It would be nice to use puppeteer-core as peer dependency.
puppeteer vs puppeteer-core.
The text was updated successfully, but these errors were encountered: