Missing puppeteer-extra peer dependency

[rtritto]

Transitive puppeteer-extra peer dependency must be included in each dependency:

• puppeteer-extra-plugin-anonymize-ua
• puppeteer-extra-plugin-block-resources
• puppeteer-extra-plugin-click-and-wait
• puppeteer-extra-plugin-devtools
• puppeteer-extra-plugin-flash
• puppeteer-extra-plugin-font-size
• puppeteer-extra-plugin-repl
• puppeteer-extra-plugin-stealth
• puppeteer-extra-plugin-user-data-dir
• puppeteer-extra-plugin-user-preferences

Changes

package.json

"peerDependencies": {
+  "puppeteer-extra": "*",
  ...
}

[berstend]

Is this a hypothetical issue or a real-life one? npm changed their behavior around peer dependencies a while back, if I recall correctly

[rtritto]

Steps to reproduce:

1. yarn init -y
2. yarn set version canary
3. yarn add puppeteer puppeteer-extra puppeteer-extra-plugin-stealth

Output:

➤ YN0000: ┌ Resolution step
➤ YN0002: │ puppeteer-extra-plugin-stealth@npm:2.10.0 doesn't provide puppeteer-extra (p716a8), requested by puppeteer-extra-plugin
➤ YN0002: │ puppeteer-extra-plugin-user-data-dir@npm:2.3.1 doesn't provide puppeteer-extra (pbf180), requested by puppeteer-extra-plugin
➤ YN0002: │ puppeteer-extra-plugin-user-preferences@npm:2.3.1 doesn't provide puppeteer-extra (p3e49e), requested by puppeteer-extra-plugin
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed

Edit:
Source

[berstend]

Given we now introduced playwright-extra (#664) which is able to load in those plugins we probably want to do the exact opposite and remove all peer dependencies 😄

Therefore closing this for now

[rtritto]

@berstend I don't know if you should consider to use optional peer dependency:

"peerDependencies": {
  "puppeteer-extra": "*",
},
"peerDependenciesMeta": {
  "puppeteer-extra": {
    "optional": true
  }
}

[berstend]

The whole situation with peer dependencies is messy :-/

npm/cli#1247 (comment)

I wonder what the best behavior from our perspective would be, warning but not auto-installing?

[rtritto]

With optional = true, peer dependencies will not be installed. Source: npm/rfcs#221 (comment)

Maybe, we can ask some help to arcanis and merceyz from yarn.