Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[puppeteer-extra-plugin-adblocker] Missing puppeteer peer dependency #644

Closed
rtritto opened this issue Jun 2, 2022 · 4 comments
Closed
Labels
issue: bug report A bug has been reported needs triage

Comments

@rtritto
Copy link

rtritto commented Jun 2, 2022

puppeteer is a peer dependency of @cliqz/adblocker-puppeteer, so must include it as peer dependency (transitive peer dependencies).

Changes

package.json

"peerDependencies": {
+  "puppeteer": "*",
  ...
}
@rtritto rtritto added issue: bug report A bug has been reported needs triage labels Jun 2, 2022
@berstend
Copy link
Owner

Closing in favor of #645

@berstend
Copy link
Owner

berstend commented Jul 7, 2022

@rtritto reopening this, can you give an example on how this is an issue?

@rtritto
Copy link
Author

rtritto commented Jul 7, 2022

Simply try and see the output:

  1. yarn init -y
  2. yarn set version canary
  3. yarn add puppeteer puppeteer-extra puppeteer-extra-plugin-adblocker

@berstend
Copy link
Owner

berstend commented Jul 7, 2022

Successfully published:
 - [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug report A bug has been reported needs triage
Projects
None yet
Development

No branches or pull requests

2 participants