Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit, this is now live: https://github.com/berstend/puppeteer-extra/tree/master/packages/playwright-extra
This PR:
playwright-extra
packagePuppeteerExtraPlugin
(and expecting certain puppeteer methods) can be used with itThis approach is much more sane as opposed to switching everything to a new shared plugin base class at once, as attempted in #303
Further background on the reasoning behind this strategy change can be found here: #454 (comment)
The code (informed by maintaining a plugin framework for 4 years now 😄) is in parts much more elegant than puppeteer-extra and once some overdue housekeeping in the repo has been done I plan to refactor puppeteer-extra as well
The next steps are
Eventually