Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT) Change #4133

Closed
8 tasks done
CarlyCotton opened this issue Dec 17, 2024 · 2 comments
Closed
8 tasks done

SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT) Change #4133

CarlyCotton opened this issue Dec 17, 2024 · 2 comments
Assignees
@andrepestana-aot @CarlyCotton
Milestone
Post Part-Time Pr...

Comments

@CarlyCotton
Copy link
Collaborator

CarlyCotton commented Dec 17, 2024 •
edited by andrepestana-aot
Loading

User Story
When SIMS uses the bridge file information, we need to disregard any cancelled PT applications.

Acceptance Criteria

image.png

  • Program year limit amounts for applications that have been cancelled should be ignored
  • Should not trigger date overlap validation if application has been cancelled (cancelled apps should be ignored during this process)
  • Ignore cancelled PT Apps when considering in the MSFAA process
  • Ignore cancelled FT Apps when considering in the MSFAA process

Additional Context
Similar work was done on #4041 (PR #4042)

Technical

  • Create a new column and save the new canceled date.
  • E2E Tests
  • Please note that the AC business that reads "[[WAITING ON FILE FROM HARRY]]" should be removed prior to development. If not appended to the end as expected the points here assigned should be invalidated.
@CarlyCotton CarlyCotton added the Business Items under Business Consideration label Dec 17, 2024
@CarlyCotton CarlyCotton self-assigned this Dec 17, 2024
@CarlyCotton CarlyCotton changed the title SFAS to SIMS Bridge - PT App Cancellation Date SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT) Change Dec 19, 2024
@CarlyCotton CarlyCotton added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Dec 19, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Dec 19, 2024
@CarlyCotton
Copy link
Collaborator Author

Updated the ACs to include the file layout change and a screenshot of the new field

@andrepestana-aot andrepestana-aot self-assigned this Dec 20, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 24, 2024
@andrepestana-aot
#4133 - SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT…
f0253be 
…) Change - Part 1 (#4175)

- Migration to add `application_date_column` to
`sims.sfas_part_time_applications`


![image](https://github.com/user-attachments/assets/341374ff-f6a0-4c8d-8329-e669cd1f72a9)
github-merge-queue bot pushed a commit that referenced this issue Dec 26, 2024
@andrepestana-aot
#4133 - SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT…
454f69b 
…) Change - part 2 (#4178)

Integration and test part.

- Added new column to model; 
- Added application cancel date;
- Added assert to integration test;
github-merge-queue bot pushed a commit that referenced this issue Dec 30, 2024
@andrepestana-aot
#4133 - SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT…
b35b5f1 
…) Change - Part 3 (#4182)

- Changed logic to: 
- Not consider part-time SFAS cancelled applications for program year
totals;
  - Not consider part-time application date overlap and; 
- Ignore full-time and part-time applications in the MSFAA number
process.
- Added E2E tests;
@CarlyCotton
Copy link
Collaborator Author

Reviewed on 2024-12-31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrepestana-aot andrepestana-aot

@CarlyCotton CarlyCotton

Labels
None yet
Projects
None yet
Milestone
Post Part-Time Primera Importante Mucho
Development

No branches or pull requests
4 participants
@andrewsignori-aot @andrepestana-aot @CarlyCotton @AnnaPBashkatova