Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: SINF restriction bridge mapping and rename to SINR #3831

Closed
6 tasks done
Joshua-Lakusta opened this issue Oct 24, 2024 · 0 comments
Closed
6 tasks done

Hotfix: SINF restriction bridge mapping and rename to SINR #3831

Joshua-Lakusta opened this issue Oct 24, 2024 · 0 comments
Assignees
@Joshua-Lakusta @lewischen-aot
Labels
Integration User Story
Milestone
2.X Post Part-Tim...

Comments

@Joshua-Lakusta
Copy link
Collaborator

Joshua-Lakusta commented Oct 24, 2024 •
edited by lewischen-aot
Loading

As a ministry user I want the SINF restriction from SFAS/SAIL to be mapped to Legacy when bridged. We also need to rename the SIMS restriction code SINF to SINR. This is important to avoid confusion for ministry users.

Acceptance Criteria

  • Change restriction code SINF to SINR
  • Update the activity page accordion code to SINR
  • We want SINR to have nothing mapping to it from the legacy system. The previous restriction from SAIL/SFAS SINF will now be mapped to Legacy.

Additional Context

  • There does not need to be any change to the function of the restriction
  • This change is being done due to risks around confusion for SFAS restriction naming
  • The reason we are remapping SINF from SFAS SAIL is due to the fact that the old restrictions on SINF has no relation to our system as we re validate SIN anyway and it is actually mapped incorrectly at this time as SINF in Legacy had a different function then SINF in SIMs.

Techincal

  • Create a DB migration to change the code of the SINF to SINR.
  • Renamed the SINF in the existing RestrictionCode enum.
  • Change an existing E2E to ensure SINF will be mapped to LGCY. Consider looking to replace one of the restrictions in the file SFAS-TO-SIMS-2024MAR07-LEGACY-RESTRICTIONS.txt.
@Joshua-Lakusta Joshua-Lakusta self-assigned this Oct 24, 2024
@Joshua-Lakusta Joshua-Lakusta added the Business Items under Business Consideration label Oct 24, 2024
@JerPearson JerPearson changed the title SINF restriction bridge mapping and rename to SINX SINF restriction bridge mapping and rename to SINR Oct 24, 2024
@ninosamson ninosamson added Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Oct 24, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Oct 24, 2024
@lewischen-aot lewischen-aot self-assigned this Oct 25, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2024
@lewischen-aot
#3831 - SINF restriction bridge mapping and rename to SINR (#3846)
3ed8c2e 
- Changed restriction code `SINF` to `SINR`
- Updated the activity page accordion code to `SINR`
- Created a DB migration to change the code of the `SINF` to `SINR`.
- Renamed `SINF` to `SINR` in the existing `RestrictionCode` enum.
- Changed an existing E2E to ensure `SINF` will be mapped to `LGCY`. 
- Replaced "TREE" with "SINF" in file
"SFAS-TO-SIMS-2024MAR07-LEGACY-RESTRICTIONS.txt" to ensure `SINF`
mapping to `LGCY` for this PR.

### Rollback evidence screenshot

![image](https://github.com/user-attachments/assets/2002ad83-4af3-4ab5-9b9c-3226e02b28e8)

Screenshot of the SINR code on the activity page accordion

![image](https://github.com/user-attachments/assets/c1b4028c-c92b-447a-b417-a10fc8c75f04)

Screenshot of the `sfas_student` table having two records after
restrictions are imported

![image](https://github.com/user-attachments/assets/1b0d2812-3944-4a15-9641-fabe894cbcf4)

Screenshot of the `student_restrictions` table having only one record
with restriction_id = 72 (LGCY)

![image](https://github.com/user-attachments/assets/20e3396d-96db-4190-941a-9e597f945ba8)

Screenshot of the completed job for processing the SINR record on Bull
Dashboard

![image](https://github.com/user-attachments/assets/50db6edd-3070-4e25-80c3-db1ff1a60be0)
@ninosamson ninosamson changed the title SINF restriction bridge mapping and rename to SINR Hotfix: SINF restriction bridge mapping and rename to SINR Oct 30, 2024
dheepak-aot pushed a commit that referenced this issue Oct 30, 2024
@lewischen-aot @dheepak-aot
#3831 - SINF restriction bridge mapping and rename to SINR (#3846)
3445832 
- Changed restriction code `SINF` to `SINR`
- Updated the activity page accordion code to `SINR`
- Created a DB migration to change the code of the `SINF` to `SINR`.
- Renamed `SINF` to `SINR` in the existing `RestrictionCode` enum.
- Changed an existing E2E to ensure `SINF` will be mapped to `LGCY`. 
- Replaced "TREE" with "SINF" in file
"SFAS-TO-SIMS-2024MAR07-LEGACY-RESTRICTIONS.txt" to ensure `SINF`
mapping to `LGCY` for this PR.

### Rollback evidence screenshot

![image](https://github.com/user-attachments/assets/2002ad83-4af3-4ab5-9b9c-3226e02b28e8)

Screenshot of the SINR code on the activity page accordion

![image](https://github.com/user-attachments/assets/c1b4028c-c92b-447a-b417-a10fc8c75f04)

Screenshot of the `sfas_student` table having two records after
restrictions are imported

![image](https://github.com/user-attachments/assets/1b0d2812-3944-4a15-9641-fabe894cbcf4)

Screenshot of the `student_restrictions` table having only one record
with restriction_id = 72 (LGCY)

![image](https://github.com/user-attachments/assets/20e3396d-96db-4190-941a-9e597f945ba8)

Screenshot of the completed job for processing the SINR record on Bull
Dashboard

![image](https://github.com/user-attachments/assets/50db6edd-3070-4e25-80c3-db1ff1a60be0)
@dheepak-aot dheepak-aot mentioned this issue Oct 30, 2024
Merged
dheepak-aot added a commit that referenced this issue Oct 30, 2024
@dheepak-aot
#260 - File integration fix - Cherry Pick Commit (#3861)
4225439 
## Cherry pick commits

The following commits are cherry picked and committed into
`file-integration-fix/cherry-pick-branch` branch from `main` branch.

- #3833 - SIN Validation - Gender Field Limit - Commit:8040205 - SHA:
8040205
- #3831 - SINF restriction bridge mapping and rename to SINR -
Commit:3ed8c2e - SHA: 3ed8c2e
- #3825 - Virus Scanning - Not functioning PROD - Commit: 5bb5050 - SHA:
5bb5050
- #3745 - Modify process that reads SIN & CRA verification response
files - Commit: 20fcda4 - SHA: 20fcda4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Joshua-Lakusta Joshua-Lakusta

@lewischen-aot lewischen-aot

Labels
Integration User Story
Projects
None yet
Milestone
2.X Post Part-Time Priorities
Development

No branches or pull requests
4 participants
@ninosamson @andrewsignori-aot @Joshua-Lakusta @lewischen-aot