Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIN Validation - Gender Field Limit #3833

Closed
2 tasks
ninosamson opened this issue Oct 24, 2024 · 0 comments
Closed
2 tasks

SIN Validation - Gender Field Limit #3833

ninosamson opened this issue Oct 24, 2024 · 0 comments
Assignees
@andrepestana-aot
Labels
Bug Something isn't working Integration
Milestone
Post Part-Time Pr...

Comments

@ninosamson
Copy link
Collaborator

ninosamson commented Oct 24, 2024 •
edited
Loading

Describe the Bug
When creating SIN Validation request, the process is erroring out because the gender field length for "prefer not to answer" exceeds the column limit.

Expected Behaviour
SIN validation should be able to handle all gender types.

Actual Behaviour
The SIN validation process fails due to "prefer not to answer"

  • Increase the column length from 10 to 50 on SIN Validation to handle "prefer not to answer option"
  • validate with student profile with "prefer not to answer" as gender
@ninosamson ninosamson added Bug Something isn't working Business Items under Business Consideration Dev & Architecture Development and Architecture and removed Business Items under Business Consideration labels Oct 24, 2024
@andrewsignori-aot andrewsignori-aot removed the Dev & Architecture Development and Architecture label Oct 24, 2024
@andrepestana-aot andrepestana-aot self-assigned this Oct 25, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 25, 2024
@andrepestana-aot
#3833 - SIN Validation - Gender Field Limit (#3839)
8040205 
Altered sims.sin_validations.gender_sent to be VARCHAR(50).

Tested with a pending SIN Validation:


![image](https://github.com/user-attachments/assets/45a94faa-8b2d-40f5-b01d-ab0af6ef3e00)

After running sin-validation-process-integration:


![image](https://github.com/user-attachments/assets/df3fa497-85ad-49f0-9355-9edcba8f8ca7)


Revert: 

![image](https://github.com/user-attachments/assets/104766b5-d103-478a-a904-e7b732cafb16)
dheepak-aot pushed a commit that referenced this issue Oct 30, 2024
@andrepestana-aot @dheepak-aot
#3833 - SIN Validation - Gender Field Limit (#3839)
28c5fac 
Altered sims.sin_validations.gender_sent to be VARCHAR(50).

Tested with a pending SIN Validation:


![image](https://github.com/user-attachments/assets/45a94faa-8b2d-40f5-b01d-ab0af6ef3e00)

After running sin-validation-process-integration:


![image](https://github.com/user-attachments/assets/df3fa497-85ad-49f0-9355-9edcba8f8ca7)


Revert: 

![image](https://github.com/user-attachments/assets/104766b5-d103-478a-a904-e7b732cafb16)
@dheepak-aot dheepak-aot mentioned this issue Oct 30, 2024
Merged
dheepak-aot added a commit that referenced this issue Oct 30, 2024
@dheepak-aot
#260 - File integration fix - Cherry Pick Commit (#3861)
4225439 
## Cherry pick commits

The following commits are cherry picked and committed into
`file-integration-fix/cherry-pick-branch` branch from `main` branch.

- #3833 - SIN Validation - Gender Field Limit - Commit:8040205 - SHA:
8040205
- #3831 - SINF restriction bridge mapping and rename to SINR -
Commit:3ed8c2e - SHA: 3ed8c2e
- #3825 - Virus Scanning - Not functioning PROD - Commit: 5bb5050 - SHA:
5bb5050
- #3745 - Modify process that reads SIN & CRA verification response
files - Commit: 20fcda4 - SHA: 20fcda4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrepestana-aot andrepestana-aot

Labels
Bug Something isn't working Integration
Projects
None yet
Milestone
Post Part-Time Primera Importante Mucho
Development

No branches or pull requests
4 participants
@ninosamson @andrewsignori-aot @andrepestana-aot @michesmith