Release v1.0.0 to main merge #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes as part of this PR: - Patroni deployment is changed, going forward we are not building in tools namespace and deploying them. We use the reference as per sample shared by BCGOV https://github.com/bcgov/patroni-postgres-container/blob/master/samples/deploy.yaml for further deployments. - Network Policies removed which are not used. - Role Bindings for github actions will be added as part of init-oc command. - Removed the secrets that are not used and removed the obselete methods - WORKFLOW_SA_USER_NAME - WORKFLOW_SA_PASSWORD - SIMS_API_CLIENT_ID - SIMS_API_CLIENT_SECRET
Formio permission change in the dockerfile while build. The tried combinations are 640, 644, 650, 654, 750, 754, 770, 774 and 777. So with the least permission level of 770, 774 and 777 which worked. Selected 770.
…ploy split (#2000) Split the github action workflow which currently builds and deploys simultaneously in a single action into seperate build and deploy github action.
Updating the `release/v1.0.0` branch with the latest changes on Openshift files.
Redis cluster command changed, as part of makefile to run in any
terminal(Windows/ mac/ Linux).
- Issue was when trying to get the jsonpath `oc get pods -n $(NAMESPACE)
-l app=redis -o jsonpath='{range .items[*]}{.status.podIP}:6379 ` in mac
it appends an additional ` :6379 `at the end, so to solve it removing
the generated one using the sed command.
- Also running the oc commands inside the redis-cli was not working, so
created variables to fetch the commands output and ran the cluster
creation.
Documentation and wiki documentation are updated
- Added a max value to the page number that is globally used for all API endpoints that have pagination enabled. This fix the 45 issues on Wava identified in the category `Integer Overflow`. - Added an E2E test to one of the endpoints mentioned on the Wava scan: `confirmation-of-enrollment/enrollmentPeriod/current?page=99999999999999999999&pageLimit=10`. This E2E test case file was used because it already has tests created and it was easier to have this one added. - The issues on the category `API Mass Assignment` are not part of this PR. Further details on the associated ticket.
- Removed the fields in the service definition, which does not allow the connections of other pods to the stateful set. - Enable db-migration scripts to run on atleast one pod when revert is needed, so enabled it in API pod
- Update the Education Program NOC code to accept 5 digits. - No DB updates are required for the existing ones as per agreed by @JasonCTang.
|
Kudos, SonarCloud Quality Gate passed!
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
andrewsignori-aot
requested review from
guru-aot,
henryoforeh-dev,
sh16011993,
dheepak-aot,
ann-aot,
andrepestana-aot and
JasonCTang
and removed request for
henryoforeh-dev
guru-aot
reviewed
Jun 26, 2023
| - [Database Migration](./docs/howto/db-migration.md) | ||
| - [Keycloak Configuration](./docs/hotwot/keycloak-config.md) | ||
| - [Keycloak Configuration](https://github.com/bcgov/SIMS/wiki/Keycloak-Config) |
There was a problem hiding this comment.
👍 Now the links will work 😄
guru-aot
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the changes for Release v1.0.0 into the main branch.