#1959 - Staging sims prod environment -Part 1 #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guru-aot
changed the title
guru-aot
changed the title
guru-aot
requested review from
andrewsignori-aot,
ann-aot,
sh16011993,
dheepak-aot,
andrepestana-aot and
JasonCTang
ann-aot
reviewed
Jun 7, 2023
| * @param clientId Client ID. | ||
| * @returns token | ||
| */ | ||
| public async getTokenFromClientSecret( |
There was a problem hiding this comment.
why was this removed? was this for formio
There was a problem hiding this comment.
Yes it was obsolete and do not have any reference
There was a problem hiding this comment.
@ann-aot it was not for form.io but it was no longer used.
ann-aot
reviewed
Jun 7, 2023
sources/packages/backend/apps/api/src/services/auth/tokens.service.ts
Outdated
Show resolved
Hide resolved
ann-aot
approved these changes
Jun 7, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Thanks for doing the cleanup 😉
andrewsignori-aot
approved these changes
Jun 7, 2023
E2E Workflow Workers Coverage Report
|
Backend Unit Tests Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
approved these changes
Jun 8, 2023
andrewsignori-aot
pushed a commit
that referenced
this pull request
Jun 8, 2023
Changes as part of this PR: - Patroni deployment is changed, going forward we are not building in tools namespace and deploying them. We use the reference as per sample shared by BCGOV https://github.com/bcgov/patroni-postgres-container/blob/master/samples/deploy.yaml for further deployments. - Network Policies removed which are not used. - Role Bindings for github actions will be added as part of init-oc command. - Removed the secrets that are not used and removed the obselete methods - WORKFLOW_SA_USER_NAME - WORKFLOW_SA_PASSWORD - SIMS_API_CLIENT_ID - SIMS_API_CLIENT_SECRET
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes as part of this PR: