-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1959 - Staging sims prod environment -Part 1 #1987
Conversation
* @param clientId Client ID. | ||
* @returns token | ||
*/ | ||
public async getTokenFromClientSecret( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this removed? was this for formio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it was obsolete and do not have any reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ann-aot it was not for form.io but it was no longer used.
sources/packages/backend/apps/api/src/services/auth/tokens.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 good work @guru-aot
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the cleanup 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the cleanups and updating Patroni. Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work with patroni and thanks for the clean up. 👍
Changes as part of this PR: - Patroni deployment is changed, going forward we are not building in tools namespace and deploying them. We use the reference as per sample shared by BCGOV https://github.com/bcgov/patroni-postgres-container/blob/master/samples/deploy.yaml for further deployments. - Network Policies removed which are not used. - Role Bindings for github actions will be added as part of init-oc command. - Removed the secrets that are not used and removed the obselete methods - WORKFLOW_SA_USER_NAME - WORKFLOW_SA_PASSWORD - SIMS_API_CLIENT_ID - SIMS_API_CLIENT_SECRET
Changes as part of this PR: