Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1959 - Staging sims prod environment -Part 1 #1987

Merged
merged 13 commits into from
Jun 8, 2023

Conversation

guru-aot
Copy link
Collaborator

@guru-aot guru-aot commented Jun 2, 2023

Changes as part of this PR:

  • Patroni deployment is changed, going forward we are not building in tools namespace and deploying them. We use the reference as per sample shared by BCGOV https://github.com/bcgov/patroni-postgres-container/blob/master/samples/deploy.yaml for further deployments.
  • Network Policies removed which are not used.
  • Role Bindings for github actions will be added as part of init-oc command.
  • Removed the secrets that are not used and removed the obselete methods
    • WORKFLOW_SA_USER_NAME
    • WORKFLOW_SA_PASSWORD
    • SIMS_API_CLIENT_ID
    • SIMS_API_CLIENT_SECRET

@guru-aot guru-aot changed the title Feature/#1959 staging sims prod environment #1959 - staging sims prod environment Jun 2, 2023
@guru-aot guru-aot self-assigned this Jun 2, 2023
@guru-aot guru-aot added the Devops Devops label Jun 2, 2023
@guru-aot guru-aot changed the title #1959 - staging sims prod environment #1959 - Staging sims prod environment -Part 1 Jun 7, 2023
@guru-aot guru-aot marked this pull request as ready for review June 7, 2023 20:21
* @param clientId Client ID.
* @returns token
*/
public async getTokenFromClientSecret(
Copy link
Contributor

@ann-aot ann-aot Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed? was this for formio

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was obsolete and do not have any reference

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ann-aot it was not for form.io but it was no longer used.

Copy link
Contributor

@ann-aot ann-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good work @guru-aot

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the cleanup 😉

Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the cleanups and updating Patroni. Looks good 👍

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 49.81% ( 267 / 536 )
Methods: 41.56% ( 32 / 77 )
Lines: 55.33% ( 218 / 394 )
Branches: 26.15% ( 17 / 65 )

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 17.91% ( 2086 / 11648 )
Methods: 8.27% ( 123 / 1488 )
Lines: 20.68% ( 1827 / 8835 )
Branches: 10.26% ( 136 / 1325 )

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 69.4% ( 390 / 562 )
Methods: 59.15% ( 42 / 71 )
Lines: 71.52% ( 344 / 481 )
Branches: 40% ( 4 / 10 )

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

E2E SIMS API Coverage Report

Totals Coverage
Statements: 43.54% ( 3032 / 6964 )
Methods: 37.75% ( 339 / 898 )
Lines: 48.6% ( 2526 / 5197 )
Branches: 19.22% ( 167 / 869 )

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with patroni and thanks for the clean up. 👍

@guru-aot guru-aot merged commit ce2731b into main Jun 8, 2023
@guru-aot guru-aot deleted the feature/#1959-Staging-SIMS-Prod-Environment branch June 8, 2023 15:32
@guru-aot guru-aot temporarily deployed to DEV June 8, 2023 15:49 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV June 8, 2023 15:50 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV June 8, 2023 15:50 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV June 8, 2023 15:50 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV June 8, 2023 15:50 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV June 8, 2023 15:51 — with GitHub Actions Inactive
@guru-aot guru-aot temporarily deployed to DEV June 8, 2023 15:51 — with GitHub Actions Inactive
andrewsignori-aot pushed a commit that referenced this pull request Jun 8, 2023
Changes as part of this PR:
- Patroni deployment is changed, going forward we are not building in
tools namespace and deploying them. We use the reference as per sample
shared by BCGOV
https://github.com/bcgov/patroni-postgres-container/blob/master/samples/deploy.yaml
for further deployments.
- Network Policies removed which are not used.
- Role Bindings for github actions will be added as part of init-oc
command.
- Removed the secrets that are not used and removed the obselete methods
  - WORKFLOW_SA_USER_NAME
  - WORKFLOW_SA_PASSWORD
  - SIMS_API_CLIENT_ID
  - SIMS_API_CLIENT_SECRET
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Devops Devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants