Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NOC code to accept 5 digits instead of 4 #2024

Closed
1 task done
JasonCTang opened this issue Jun 19, 2023 · 1 comment
Closed
1 task done

Update NOC code to accept 5 digits instead of 4 #2024

JasonCTang opened this issue Jun 19, 2023 · 1 comment
Assignees
@andrewsignori-aot @JasonCTang
Labels
Task

Comments

@JasonCTang
Copy link
Collaborator

JasonCTang commented Jun 19, 2023 •
edited by andrewsignori-aot
Loading

Describe the task
Federal government's new format for NOC codes is now 5 digits long and currently, our forms only accept 4 digits. Update to accept 5.

Acceptance Criteria

  • Make necessary changes to accept and store 5 digit NOC codes.
andrewsignori-aot added a commit that referenced this issue Jun 19, 2023
@andrewsignori-aot
#2024 - Changed NOC to 5 digits (#2025)
9a72ffb 
- Update the Education Program NOC code to accept 5 digits.
- No DB updates are required for the existing ones as per agreed by
@JasonCTang.
@andrewsignori-aot
Copy link
Collaborator

Changed NOC code to accept exact 5 digits.

It shows a validation error for 4 or 6 digits.

image.png

image.png

No errors when 5 digits are provided.

image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewsignori-aot andrewsignori-aot

@JasonCTang JasonCTang

Labels
Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewsignori-aot @JasonCTang