#1959 - Staging sims prod environment formio #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
guru-aot
requested review from
sh16011993,
dheepak-aot,
andrewsignori-aot,
ann-aot,
andrepestana-aot and
JasonCTang
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
dheepak-aot
reviewed
Jun 8, 2023
| @@ -48,7 +48,7 @@ RUN ln -sf $NPM_PACKAGES/node_modules node_modules | |||
| ENV DEBUG="" | |||
|
|
|||
| RUN set -x \ | |||
| && chmod -R 777 /app/ | |||
| && chmod -R 770 /app/ | |||
There was a problem hiding this comment.
Asking for clarification.
What is the standard that we are trying to comply with here (by changing permission)?
Sonar? or any security vulnerability issue from scans previously?
There was a problem hiding this comment.
We are trying to be less permissive as possible and still have the form.io server running.
There was a problem hiding this comment.
Security vulnerability to restrict others to have any permission other than the owner and group.
sh16011993
reviewed
Jun 8, 2023
E2E SIMS API Coverage Report
|
andrewsignori-aot
approved these changes
Jun 8, 2023
dheepak-aot
approved these changes
Jun 8, 2023
andrewsignori-aot
pushed a commit
that referenced
this pull request
Jun 8, 2023
Formio permission change in the dockerfile while build. The tried combinations are 640, 644, 650, 654, 750, 754, 770, 774 and 777. So with the least permission level of 770, 774 and 777 which worked. Selected 770.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formio permission change in the dockerfile while build.
The tried combinations are 640, 644, 650, 654, 750, 754, 770, 774 and 777. So with the least permission level of 770, 774 and 777 which worked. Selected 770.