Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4133 - SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT) Change - Part 1 #4175

Merged
merged 2 commits into from
Dec 24, 2024
Merged

#4133 - SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT) Change - Part 1 #4175

merged 2 commits into from
Dec 24, 2024

Conversation

andrepestana-aot
Copy link
Collaborator

  • Migration to add application_date_column to sims.sfas_part_time_applications

image

@andrepestana-aot andrepestana-aot self-assigned this Dec 23, 2024
@andrepestana-aot andrepestana-aot added DB DB migration involved Integration labels Dec 23, 2024
@andrepestana-aot andrepestana-aot changed the title #4041 - SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT) Change #4133 - SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT) Change Dec 23, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.08% ( 3785 / 17140 )
Methods: 10.09% ( 219 / 2171 )
Lines: 25.49% ( 3280 / 12870 )
Branches: 13.63% ( 286 / 2099 )

@github-actions GitHub Actions
Copy link

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

@github-actions GitHub Actions
Copy link

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 82.7% ( 1291 / 1561 )
Methods: 70.05% ( 131 / 187 )
Lines: 85.67% ( 1082 / 1263 )
Branches: 70.27% ( 78 / 111 )

@github-actions GitHub Actions
Copy link

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

@andrepestana-aot andrepestana-aot marked this pull request as ready for review December 24, 2024 17:32
@andrepestana-aot andrepestana-aot changed the title #4133 - SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT) Change #4133 - SFAS to SIMS Bridge - PT App Cancellation Date & MSFAA (FT/PT) Change - Part 1 Dec 24, 2024
andrewsignori-aot
andrewsignori-aot approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start, looks good 👍

@lewischen-aot lewischen-aot self-requested a review December 24, 2024 20:43
lewischen-aot
lewischen-aot approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@lewischen-aot lewischen-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loos good to me. Nice work 👍

@andrepestana-aot andrepestana-aot added this pull request to the merge queue Dec 24, 2024
Merged via the queue into main with commit f0253be Dec 24, 2024
21 checks passed
@andrepestana-aot andrepestana-aot deleted the 4133_sfas_to_sims_pt_app_cancellation_date_msfaa_ftpt branch December 24, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewischen-aot lewischen-aot lewischen-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

Assignees

@andrepestana-aot andrepestana-aot

Labels
DB DB migration involved Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrepestana-aot @andrewsignori-aot @lewischen-aot